Skip to content

Remove unsupported stackdriver tracing backend #5881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow-robot merged 2 commits into from
Nov 8, 2021
Merged

Remove unsupported stackdriver tracing backend #5881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6345b3b
remove unsupported stackdriver tracing backend
lionelvillard Nov 8, 2021
f61b1a7
fix hack script
lionelvillard Nov 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions config/channels/in-memory-channel/configmaps/tracing.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ metadata:
app.kubernetes.io/version: devel
app.kubernetes.io/part-of: knative-eventing
annotations:
knative.dev/example-checksum: "4002b4c2"
knative.dev/example-checksum: "c8f8c47b"
data:
_example: |
################################
Expand All @@ -41,18 +41,13 @@ data:
# this example block and unindented to be in the data block
# to actually change the configuration.
#
# This may be "zipkin" or "stackdriver", the default is "none"
# This may be "zipkin" or "none", the default is "none"
backend: "none"

# URL to zipkin collector where traces are sent.
# This must be specified when backend is "zipkin"
zipkin-endpoint: "http://zipkin.istio-system.svc.cluster.local:9411/api/v2/spans"

# The GCP project into which stackdriver metrics will be written
# when backend is "stackdriver". If unspecified, the project-id
# is read from GCP metadata when running on GCP.
stackdriver-project-id: "my-project"

# Enable zipkin debug mode. This allows all spans to be sent to the server
# bypassing sampling.
debug: "false"
Expand Down
9 changes: 2 additions & 7 deletions config/core/configmaps/tracing.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ metadata:
app.kubernetes.io/version: devel
app.kubernetes.io/part-of: knative-eventing
annotations:
knative.dev/example-checksum: "4002b4c2"
knative.dev/example-checksum: "0492ceb0"
data:
_example: |
################################
Expand All @@ -41,18 +41,13 @@ data:
# this example block and unindented to be in the data block
# to actually change the configuration.
#
# This may be "zipkin" or "stackdriver", the default is "none"
# This may be "zipkin" or "none". the default is "none"
backend: "none"

# URL to zipkin collector where traces are sent.
# This must be specified when backend is "zipkin"
zipkin-endpoint: "http://zipkin.istio-system.svc.cluster.local:9411/api/v2/spans"

# The GCP project into which stackdriver metrics will be written
# when backend is "stackdriver". If unspecified, the project-id
# is read from GCP metadata when running on GCP.
stackdriver-project-id: "my-project"

# Enable zipkin debug mode. This allows all spans to be sent to the server
# bypassing sampling.
debug: "false"
Expand Down
1 change: 1 addition & 0 deletions hack/update-checksums.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,4 @@ fi
source $(dirname $0)/../vendor/knative.dev/hack/library.sh

go run "${REPO_ROOT_DIR}/vendor/knative.dev/pkg/configmap/hash-gen" "${REPO_ROOT_DIR}"/config/core/configmaps/*.yaml
go run "${REPO_ROOT_DIR}/vendor/knative.dev/pkg/configmap/hash-gen" "${REPO_ROOT_DIR}"/config/channels/in-memory-channel/configmaps/*.yaml