Skip to content

Add test for default deadLetterSink namespace in generic Channel#5908

Merged
knative-prow-robot merged 1 commit into
knative:mainfrom
pierDipi:KNATIVE_add-defaulting-dls-namespace-test-for-gen-channel
Nov 15, 2021
Merged

Add test for default deadLetterSink namespace in generic Channel#5908
knative-prow-robot merged 1 commit into
knative:mainfrom
pierDipi:KNATIVE_add-defaulting-dls-namespace-test-for-gen-channel

Conversation

@pierDipi
Copy link
Copy Markdown
Member

See #5906 (review)

Fixes #5906 (review)

Proposed Changes

  • Add test for default deadLetterSink namespace in generic Channel

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

None

Docs

None

/assign @odacremolbap

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 15, 2021
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 15, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 15, 2021

Codecov Report

Merging #5908 (29b44fe) into main (1e9f9f1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5908   +/-   ##
=======================================
  Coverage   82.02%   82.02%           
=======================================
  Files         220      220           
  Lines        7527     7527           
=======================================
  Hits         6174     6174           
  Misses        918      918           
  Partials      435      435           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e9f9f1...29b44fe. Read the comment docs.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: odacremolbap, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit d5201e7 into knative:main Nov 15, 2021
@pierDipi pierDipi deleted the KNATIVE_add-defaulting-dls-namespace-test-for-gen-channel branch November 15, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants