Skip to content

Remove (seemingly??) unused pkg/buses#594

Closed
vaikas wants to merge 1 commit into
knative:masterfrom
vaikas:remove_buses
Closed

Remove (seemingly??) unused pkg/buses#594
vaikas wants to merge 1 commit into
knative:masterfrom
vaikas:remove_buses

Conversation

@vaikas
Copy link
Copy Markdown
Contributor

@vaikas vaikas commented Nov 8, 2018

Addresses #591

Proposed Changes

  • Remove unused files from /pkg/buses

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 8, 2018
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 8, 2018
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2018
@vaikas vaikas closed this Nov 8, 2018
@neosab
Copy link
Copy Markdown
Contributor

neosab commented Nov 8, 2018

Fanout sidecar uses pkg/bus Message Dispatcher

return f.dispatcher.DispatchMessage(&m, sub.SubscriberURI, sub.ReplyURI, buses.DispatchDefaults{})

Kafka Dispatcher uses the pkg/busMessage Dispatcher & Receiver #589

Ideally, they should be moved to proper utility packages rather than leveraging parts of the old bus implementation.

@neosab
Copy link
Copy Markdown
Contributor

neosab commented Nov 8, 2018

Ah, my bad didn't see this PR was closed.

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@vaikas-google: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-knative-eventing-unit-tests ab5b06d link /test pull-knative-eventing-unit-tests
pull-knative-eventing-build-tests ab5b06d link /test pull-knative-eventing-build-tests
pull-knative-eventing-integration-tests ab5b06d link /test pull-knative-eventing-integration-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@matzew
Copy link
Copy Markdown
Member

matzew commented Nov 9, 2018

I think the package could be named differently. I was wondering exactly the same, than noticed that it's actually used ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants