Remove (seemingly??) unused pkg/buses#594
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Fanout sidecar uses eventing/pkg/sidecar/fanout/fanout_handler.go Line 123 in 8589a29 Kafka Dispatcher uses the Ideally, they should be moved to proper utility packages rather than leveraging parts of the old bus implementation. |
|
Ah, my bad didn't see this PR was closed. |
|
@vaikas-google: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
I think the package could be named differently. I was wondering exactly the same, than noticed that it's actually used ;-) |
Addresses #591
Proposed Changes