Skip to content

don't use dep prune anymore#60

Merged
google-prow-robot merged 2 commits into
knative:masterfrom
dprotaso:master
May 25, 2018
Merged

don't use dep prune anymore#60
google-prow-robot merged 2 commits into
knative:masterfrom
dprotaso:master

Conversation

@dprotaso
Copy link
Copy Markdown
Member

dep prune is deprecated we can simply use dep ensure.

We need some modifications to the Gopkg.toml in order to keep the vendored code-generator scripts

@google-prow-robot google-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 25, 2018
@dprotaso
Copy link
Copy Markdown
Member Author

/assign vaikas-google

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented May 25, 2018

/lgtm
/approve

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2018
@google-prow-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2018
@google-prow-robot google-prow-robot merged commit 9de43f8 into knative:master May 25, 2018
matzew added a commit to matzew/eventing that referenced this pull request Apr 8, 2019
matzew added a commit to matzew/eventing that referenced this pull request Apr 8, 2019
openshift-merge-robot referenced this pull request in openshift/knative-eventing Apr 8, 2019
Replaces fix like serving PR #60
matzew added a commit to matzew/eventing that referenced this pull request Apr 11, 2019
matzew pushed a commit to matzew/eventing that referenced this pull request Apr 11, 2019
matzew added a commit to matzew/eventing that referenced this pull request Feb 9, 2023
* Add readiness and liveness probes in controller (knative#6570)

Co-authored-by: Lionel Villard <villard@us.ibm.com>

* Running make RELEASE for 1.7

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com>
Co-authored-by: Lionel Villard <villard@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants