Skip to content

[WIP] Fetch receiver report directly by Prober#6055

Closed
mgencur wants to merge 10 commits into
knative:mainfrom
mgencur:remove_fetcher
Closed

[WIP] Fetch receiver report directly by Prober#6055
mgencur wants to merge 10 commits into
knative:mainfrom
mgencur:remove_fetcher

Conversation

@mgencur
Copy link
Copy Markdown
Contributor

@mgencur mgencur commented Jan 14, 2022

Fixes #6045

Proposed Changes

  • do not use FinishedSleep before fetching the report but rather wait for the report to be complete/inactive or eventually time out
  • fetch the test report by prober directly from receiver
  • remove wathola-fetcher and its image

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note


Docs

* remove wathola-fetcher and its image
* fetch the test report directly from receiver
* do not use FinishedSleep before fetching the report but rether wait
for the report to be complete/inactive or eventually time out
@knative-prow-robot knative-prow-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Jan 14, 2022
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mgencur
To complete the pull request process, please assign chizhg after the PR has been reviewed.
You can assign the PR to them by writing /assign @chizhg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 14, 2022

Codecov Report

Merging #6055 (1f9953a) into main (2d64fdd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6055   +/-   ##
=======================================
  Coverage   82.32%   82.32%           
=======================================
  Files         225      225           
  Lines        7636     7636           
=======================================
  Hits         6286     6286           
  Misses        910      910           
  Partials      440      440           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d64fdd...1f9953a. Read the comment docs.

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@mgencur: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-knative-eventing-upgrade-tests 1f9953a link true /test pull-knative-eventing-upgrade-tests
pull-knative-eventing-integration-tests 1f9953a link true /test pull-knative-eventing-integration-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cardil
Copy link
Copy Markdown
Contributor

cardil commented Jan 20, 2022

Getting rid of fetcher isn't a good idea. Fetcher was introduced, because of collecting logs directly, turned to be problematic on all those Kubernetes distros. It should be working on OpenShift, GKE, Minikube, and Kind, at least.

See #4460

@mgencur
Copy link
Copy Markdown
Contributor Author

mgencur commented Jan 20, 2022

Thanks, closing this. Will create another PR with simpler solution, keeping Fetcher.

@mgencur mgencur closed this Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test-and-release Test infrastructure, tests or release do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[QE] Upgrade testing suffers from non-reliable await for traffic to fully pass

3 participants