Remove manual pruning of knative/test-infra#606
Merged
knative-prow-robot merged 1 commit intoNov 12, 2018
Conversation
This was removing tools we wanted to keep, like dep-collector.
knative-prow-robot
added
the
size/XXL
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grantr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
matzew
reviewed
Nov 12, 2018
| rm -rf $(find vendor/ -name 'BUILD.bazel') | ||
|
|
||
| # Keep the only dir in knative/test-infra we're interested in | ||
| find vendor/github.com/knative/test-infra -mindepth 1 -maxdepth 1 ! -name scripts -exec rm -fr {} \; |
Member
There was a problem hiding this comment.
Member
|
/lgtm tests:
|
Contributor
|
You're now vendoring the whole test-infra, which is unnecessary. The packages need to be adjusted, just like in knative/serving#2420 |
Contributor
Author
|
@adrcunha I'll create a followup PR to fix that. |
matzew
added a commit
to matzew/eventing
that referenced
this pull request
Jun 3, 2020
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
mgencur
pushed a commit
to mgencur/eventing
that referenced
this pull request
May 21, 2024
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was incorrectly removing
dep-collector, and wasn't really necessary in the first place according to @mattmoor./cc @mattmoor @adrcunha