GCP PubSub Channel#618
Merged
Merged
Conversation
…omize them per channel. We can add them back later if desired.
…tally unimplemented.
knative-prow-robot
added
the
do-not-merge/work-in-progress
knative-prow-robot
added
the
size/XXL
grantr
reviewed
Nov 26, 2018
|
|
||
| They do not offer: | ||
| * Ordering guarantees | ||
| - Events seen downstream may not occur in the same order they were inserted into the Channel. |
Contributor
There was a problem hiding this comment.
I find this particular formatting of a list of titles plus descriptions tough to take in at a glance. I prefer something more like this:
- Bold title. Normal description, all in a single list item.
- Another bold title. Another description.
grantr
reviewed
Nov 27, 2018
Contributor
grantr
left a comment
grantr
left a comment
There was a problem hiding this comment.
Partial review through channel reconciler and tests.
Contributor
|
/milestone v0.2.2 |
grantr
reviewed
Nov 30, 2018
grantr
reviewed
Nov 30, 2018
Contributor
grantr
left a comment
grantr
left a comment
There was a problem hiding this comment.
So close! All I have left is some changes to log levels, then this can go in.
| "cloud.google.com/go/pubsub" | ||
| ) | ||
|
|
||
| // This file exists so that we can unit test failures with the PubSub client. |
Contributor
There was a problem hiding this comment.
This whole setup is a heroic effort to work around a library design that is impossible to test. Thanks for taking the time to make it work @Harwayne, but I wish you didn't have to. As good open source citizens, we should probably open an issue on the pubsub client repo describing the difficulty. 😇
| limitations under the License. | ||
| */ | ||
|
|
||
| package testcreds |
Contributor
There was a problem hiding this comment.
Optional: Why is this a separate package from the actual test code?
Contributor
Author
There was a problem hiding this comment.
I didn't want to mix test code in with production code. If put into the same package as creds.go, then all the real code would also have these fake functions already imported.
It also makes for nice instantiation, testcreds.MakeSecretWithCreds().
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grantr, Harwayne The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
lberk
pushed a commit
to lberk/eventing
that referenced
this pull request
Jun 11, 2020
* 💄 tweaking CI job generation to be actually valid Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * 💄 typo Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Proper image mirror file generation Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Adding one more task execution Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Adding one more update to the ci generator Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Better promotion generation Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Script tweaks Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Optimize image and release creation Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Adding src-image to CI generator Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Adding some Release guide Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Feedback from Martin, part I Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Better comment Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
creydr
pushed a commit
to creydr/knative-eventing
that referenced
this pull request
Jun 12, 2024
Co-authored-by: Michal Vinkler <mvinkler@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #443, #444
Proposed Changes
Release Note