Skip to content

[release-1.4] Only proxy some headers from the reply in MTBroker filter#6386

Merged
knative-prow[bot] merged 2 commits into
knative:release-1.4from
knative-prow-robot:cherry-pick-6357-to-release-1.4
May 16, 2022
Merged

[release-1.4] Only proxy some headers from the reply in MTBroker filter#6386
knative-prow[bot] merged 2 commits into
knative:release-1.4from
knative-prow-robot:cherry-pick-6357-to-release-1.4

Conversation

@knative-prow-robot
Copy link
Copy Markdown
Contributor

This is an automated cherry-pick of #6357

- :broom: MTChannelBroker filter does not proxy headers from replies anymore other than the headers specified in its hardcoded allow-list. The list so far only contains `Retry-After`.

@knative-prow knative-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 15, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2022

Codecov Report

Merging #6386 (7b47b46) into release-1.4 (cb9a2b5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           release-1.4    #6386   +/-   ##
============================================
  Coverage        82.39%   82.40%           
============================================
  Files              233      233           
  Lines            11562    11567    +5     
============================================
+ Hits              9527     9532    +5     
  Misses            1572     1572           
  Partials           463      463           
Impacted Files Coverage Δ
pkg/broker/filter/filter_handler.go 75.42% <100.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb9a2b5...7b47b46. Read the comment docs.

Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2022
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2022
@knative-prow knative-prow Bot merged commit a7fa110 into knative:release-1.4 May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants