Promote strict subscriber to beta#6473
Merged
knative-prow[bot] merged 2 commits intoAug 4, 2022
Merged
Conversation
knative-prow
Bot
added
do-not-merge/work-in-progress
Codecov Report
@@ Coverage Diff @@
## main #6473 +/- ##
==========================================
+ Coverage 82.15% 82.18% +0.02%
==========================================
Files 235 235
Lines 11694 11712 +18
==========================================
+ Hits 9607 9625 +18
Misses 1620 1620
Partials 467 467
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
force-pushed
the
KNATIVE-5756_Promote-strict-subscriber-to-beta
branch
from
d0a1b39 to
512f508
Compare
knative-prow
Bot
added
size/S
Member
Author
|
/test upgrade-tests_eventing_main |
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
force-pushed
the
KNATIVE-5756_Promote-strict-subscriber-to-beta
branch
from
fb394f8 to
bf0ca1d
Compare
pierDipi
changed the title
knative-prow
Bot
removed
the
do-not-merge/work-in-progress
Member
Author
|
/assign @lionelvillard |
Contributor
|
I'm looking at the downstream failures (all related to go 1.18) /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lionelvillard, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
creydr
added a commit
to creydr/knative-eventing
that referenced
this pull request
Nov 14, 2022
…o GA As per knative/specs#30 the spec was changed from requiring one of `spec.subscriber` or `spec.reply` to be set to require that `spec.subscriber` is set. As part of this change the `strict-subscriber` feature flag was introduced to disable this validation and promoted to beta (enabled by default) in 1.7 (knative#6473). This commit removes this feature flag again so the validation can't be disabled anymore. Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
5 tasks
creydr
added a commit
to creydr/knative-eventing
that referenced
this pull request
Nov 16, 2022
…o GA As per knative/specs#30 the spec was changed from requiring one of `spec.subscriber` or `spec.reply` to be set to require that `spec.subscriber` is set. As part of this change the `strict-subscriber` feature flag was introduced to disable this validation and promoted to beta (enabled by default) in 1.7 (knative#6473). This commit removes this feature flag again so the validation can't be disabled anymore. Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
creydr
added a commit
to creydr/knative-eventing
that referenced
this pull request
Nov 16, 2022
…o GA As per knative/specs#30 the spec was changed from requiring one of `spec.subscriber` or `spec.reply` to be set to require that `spec.subscriber` is set. As part of this change the `strict-subscriber` feature flag was introduced to disable this validation and promoted to beta (enabled by default) in 1.7 (knative#6473). This commit removes this feature flag again so the validation can't be disabled anymore. Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
knative-prow Bot
pushed a commit
that referenced
this pull request
Nov 16, 2022
Fixes #5756 As per knative/specs#30 the spec was changed from requiring one of `spec.subscriber` or `spec.reply` to be set to require that `spec.subscriber` is set. As part of this change the `strict-subscriber` feature flag was introduced to disable this validation (#5762) and promoted to beta (enabled by default) in 1.7 (#6473). :broom: This commit removes this feature flag again so the validation can't be disabled anymore. ## Proposed Changes * Remove `strict-subscriber` feature flag * Promote strict subscriber validation to GA ### Pre-review Checklist - [ ] **At least 80% unit test coverage** - [ ] **E2E tests** for any new behavior - [ ] **Docs PR** for any user-facing impact - [ ] **Spec PR** for any new API feature - [ ] **Conformance test** for any change to the spec **Release Note** ```release-note Remove the possibility to disable strict subscriber validation. When the reply field is specified without a subscriber, the reply field won't be used as a subscriber by default and the subscriber validation will fail. ``` Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pierangelo Di Pilato pierdipi@redhat.com
Part of #5756
Proposed Changes
Pre-review Checklist
Release Note