-
Notifications
You must be signed in to change notification settings - Fork 620
[release-1.5] Remove strict check in scorer plugins and respect maxskew, requeue when no pods available rather than fail Scheduler #6526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…en no pods available rather than fail scheduler Signed-off-by: aavarghese <avarghese@us.ibm.com>
…/nodes with no schedulable pods Signed-off-by: aavarghese <avarghese@us.ibm.com>
aavarghese
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Codecov ReportBase: 82.03% // Head: 82.01% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## release-1.5 #6526 +/- ##
===============================================
- Coverage 82.03% 82.01% -0.02%
===============================================
Files 235 235
Lines 11713 11706 -7
===============================================
- Hits 9609 9601 -8
- Misses 1634 1636 +2
+ Partials 470 469 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
/cc @pierDipi |
pierDipi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aavarghese, knative-prow-robot, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #6524