Skip to content

Conversation

@knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #6524

Remove strict check in scorer plugins and respect max skew parameter. Requeue request when no pods available rather than fail scheduler.

…en no pods available rather than fail scheduler

Signed-off-by: aavarghese <avarghese@us.ibm.com>
…/nodes with no schedulable pods

Signed-off-by: aavarghese <avarghese@us.ibm.com>
Copy link
Contributor

@aavarghese aavarghese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 81.98% // Head: 81.96% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (60e0fd2) compared to base (6ffef0f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.7    #6528      +/-   ##
===============================================
- Coverage        81.98%   81.96%   -0.02%     
===============================================
  Files              235      235              
  Lines            11733    11726       -7     
===============================================
- Hits              9619     9611       -8     
- Misses            1642     1644       +2     
+ Partials           472      471       -1     
Impacted Files Coverage Δ
...labilitynodepriority/availability_node_priority.go 81.39% <ø> (+11.18%) ⬆️
...labilityzonepriority/availability_zone_priority.go 82.60% <ø> (+11.18%) ⬆️
pkg/scheduler/scheduler.go 100.00% <ø> (ø)
pkg/scheduler/statefulset/scheduler.go 79.13% <100.00%> (-2.80%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aavarghese
Copy link
Contributor

/cc @pierDipi
I don't have approval powers :)

@knative-prow knative-prow bot requested a review from pierDipi September 21, 2022 11:46
@knative-prow
Copy link

knative-prow bot commented Sep 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aavarghese, knative-prow-robot, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2022
@knative-prow knative-prow bot merged commit 9967e86 into knative:release-1.7 Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants