Skip to content

Conversation

@matzew
Copy link
Member

@matzew matzew commented Sep 28, 2022

Signed-off-by: Matthias Wessendorf mwessend@redhat.com

Proposed Changes

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note


Docs

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 28, 2022
@matzew
Copy link
Member Author

matzew commented Sep 28, 2022

/hold

feel free to unhold once https://github.com/knative/pkg/pull/2595/files landed and is propagated to here (via dep. updates)

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 28, 2022
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 81.94% // Head: 81.94% // No change to project coverage 👍

Coverage data is based on head (da1ac80) compared to base (bd37622).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6548   +/-   ##
=======================================
  Coverage   81.94%   81.94%           
=======================================
  Files         235      235           
  Lines       11738    11738           
=======================================
  Hits         9619     9619           
  Misses       1646     1646           
  Partials      473      473           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matzew
Copy link
Member Author

matzew commented Sep 28, 2022

Related: knative/pkg#2595

@matzew matzew mentioned this pull request Sep 28, 2022
5 tasks
@matzew
Copy link
Member Author

matzew commented Sep 30, 2022

/unhold
looks like the pkg change is ready... so it would be nice to remove the 1.22 BEFORE the dependency update PR will fail (on kind)

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2022
Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2022
@knative-prow
Copy link

knative-prow bot commented Sep 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Member Author

matzew commented Sep 30, 2022

/test upgrade-tests

@knative-prow knative-prow bot merged commit 7527528 into knative:main Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants