CreateK8sService diffs its expected spec against the actual spec and updates the K8s Service appropriately#666
Merged
Conversation
…updates the K8s Service appropriately.
knative-prow-robot
added
the
do-not-merge/work-in-progress
knative-prow-robot
added
the
size/L
Contributor
Author
|
/retest |
|
The following is the coverage report on pkg/.
|
Harwayne
changed the title
knative-prow-robot
removed
the
do-not-merge/work-in-progress
Contributor
Author
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, Harwayne The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Harwayne
added a commit
to Harwayne/knative-eventing
that referenced
this pull request
Dec 5, 2018
knative-prow-robot
pushed a commit
that referenced
this pull request
Dec 5, 2018
mgencur
pushed a commit
to mgencur/eventing
that referenced
this pull request
Jun 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up of sorts on #626, which did this for
VirtualServicesand the Dispatcher's K8sService.Proposed Changes
CreateK8sServicediffs against any found K8sServiceand updates it if the spec is different than expected.Release Note