Skip to content

Pin sources release to last known good#683

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
grantr:pin-test-sources-release
Dec 7, 2018
Merged

Pin sources release to last known good#683
knative-prow-robot merged 1 commit into
knative:masterfrom
grantr:pin-test-sources-release

Conversation

@grantr
Copy link
Copy Markdown
Contributor

@grantr grantr commented Dec 7, 2018

Trying to unblock tests while we track down the failure in sources.

This will unblock tests while we track down failures in sources.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 7, 2018
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 7, 2018
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2018
@evankanderson
Copy link
Copy Markdown
Member

We should consider using a release here now that we have it, rather than the latest nightly.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2018
@grantr
Copy link
Copy Markdown
Contributor Author

grantr commented Dec 7, 2018

I'm fine with using the versioned release. FWIW the tests use the nightly release of serving:

readonly KNATIVE_SERVING_RELEASE=https://storage.googleapis.com/knative-nightly/serving/latest/release.yaml

@vaikas-google thoughts?

@knative-prow-robot knative-prow-robot merged commit 0497fa7 into knative:master Dec 7, 2018
@grantr grantr deleted the pin-test-sources-release branch December 7, 2018 18:18
@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Dec 7, 2018

I think it depends on what we're testing. I think we should know asap if say eventing-sources are not going to work with eventing anymore.
So, we should probably from Eventing test against a known good.
eventing-sources should probably test against the head to know if something there will break against eventing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants