Skip to content

Point tests to the latest nightly eventing-sources #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bbrowning wants to merge 2 commits into from
Closed

Point tests to the latest nightly eventing-sources #719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a6d9f4
Point tests to the latest nightly eventing-sources
bbrowning Jan 11, 2019
a29e9d2
Fix test namespaces to match passing test in eventing-sources
bbrowning Jan 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions test/e2e-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,7 @@

source $(dirname $0)/../vendor/github.com/knative/test-infra/scripts/e2e-tests.sh

# Using the most recent good release of eventing-sources to unblock tests. This
# should be replaced with the commented line below when eventing-sources nightly
# is known good again.
readonly KNATIVE_EVENTING_SOURCES_RELEASE=https://knative-nightly.storage.googleapis.com/eventing-sources/previous/v20181205-fbac942/release.yaml
#readonly KNATIVE_EVENTING_SOURCES_RELEASE=https://knative-nightly.storage.googleapis.com/eventing-sources/latest/release.yaml
readonly KNATIVE_EVENTING_SOURCES_RELEASE=https://knative-nightly.storage.googleapis.com/eventing-sources/latest/release.yaml

# Names of the Resources used in the tests.
readonly E2E_TEST_NAMESPACE=e2etest
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/e2e.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ func CreateServiceAccountAndBinding(clients *test.Clients, name string, logger *
sa := &corev1.ServiceAccount{
ObjectMeta: metav1.ObjectMeta{
Name: name,
Namespace: defaultNamespaceName,
Namespace: pkgTest.Flags.Namespace,
},
}
err := CreateServiceAccount(clients, sa, logger, cleaner)
Expand All @@ -172,7 +172,7 @@ func CreateServiceAccountAndBinding(clients *test.Clients, name string, logger *
{
Kind: "ServiceAccount",
Name: name,
Namespace: defaultNamespaceName,
Namespace: pkgTest.Flags.Namespace,
},
},
RoleRef: rbacv1.RoleRef{
Expand Down
6 changes: 3 additions & 3 deletions test/e2e/k8s_events_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,14 @@ func TestKubernetesEvents(t *testing.T) {
}

logger.Infof("Creating Channel")
channel := test.Channel(channelName, defaultNamespaceName, test.ClusterChannelProvisioner(provisionerName))
channel := test.Channel(channelName, pkgTest.Flags.Namespace, test.ClusterChannelProvisioner(provisionerName))
err = CreateChannel(clients, channel, logger, cleaner)
if err != nil {
t.Fatalf("Failed to create Channel: %v", err)
}

logger.Infof("Creating EventSource")
k8sSource := test.KubernetesEventSource(eventSource, defaultNamespaceName, testNamespace, serviceAccount, test.ChannelRef(channelName))
k8sSource := test.KubernetesEventSource(eventSource, pkgTest.Flags.Namespace, testNamespace, serviceAccount, test.ChannelRef(channelName))
err = CreateKubernetesEventSource(clients, k8sSource, logger, cleaner)
if err != nil {
t.Fatalf("Failed to create KubernetesEventSource: %v", err)
Expand All @@ -74,7 +74,7 @@ func TestKubernetesEvents(t *testing.T) {
}

logger.Infof("Creating Subscription")
subscription := test.Subscription(subscriptionName, defaultNamespaceName, test.ChannelRef(channelName), test.SubscriberSpecForRoute(routeName), nil)
subscription := test.Subscription(subscriptionName, pkgTest.Flags.Namespace, test.ChannelRef(channelName), test.SubscriberSpecForRoute(routeName), nil)
err = CreateSubscription(clients, subscription, logger, cleaner)
if err != nil {
t.Fatalf("Failed to create Subscription: %v", err)
Expand Down