Skip to content

Updating Copyright to 2019#748

Closed
nachocano wants to merge 1 commit into
knative:masterfrom
nachocano:master
Closed

Updating Copyright to 2019#748
nachocano wants to merge 1 commit into
knative:masterfrom
nachocano:master

Conversation

@nachocano
Copy link
Copy Markdown
Contributor

@nachocano nachocano commented Jan 24, 2019

Proposed Changes

  • Changing Copyright to 2019 in every file

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 24, 2019
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 24, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nachocano
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: vaikas-google

If they are not already assigned, you can assign the PR to them by writing /assign @vaikas-google in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nachocano
Copy link
Copy Markdown
Contributor Author

/assign @grantr

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Jan 24, 2019

So, do we really want to blanket change all the copyright for old files or only for the new ones? In the past in other projects, I've gotten used to that new files get stamped with the year they were created vs. updating files every year. Just curious.

@evankanderson
Copy link
Copy Markdown
Member

I believe the copyright should be for the year of initial publication, but I can introduce you to our counsel to get appropriate legal advice.

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2019
@nachocano
Copy link
Copy Markdown
Contributor Author

@evankanderson sounds good.

@nachocano
Copy link
Copy Markdown
Contributor Author

@vaikas-google I think we will need to at least update the autogen files with the new boilerplate, otherwise it seems that build-tests breaks. See Grant's comment

@grantr
Copy link
Copy Markdown
Contributor

grantr commented Jan 24, 2019

I initially thought the build tests failed in #746 because the build test was verifying the boilerplate for all files, but that was my mistake: it's actually just verifying that generated code is current, and changing the boilerplate header changed the generated code.

Based on @vaikas-google's and @evankanderson's comments above, I recommend closing this PR and opening a new one that only updates the boilerplate file and the generated code.

While we're talking to counsel, we should ask them how to handle the copyright year on generated code.

@nachocano
Copy link
Copy Markdown
Contributor Author

Closing this PR then

@nachocano nachocano closed this Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants