Updating Copyright to 2019#748
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nachocano If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/assign @grantr |
|
So, do we really want to blanket change all the copyright for old files or only for the new ones? In the past in other projects, I've gotten used to that new files get stamped with the year they were created vs. updating files every year. Just curious. |
|
I believe the copyright should be for the year of initial publication, but I can introduce you to our counsel to get appropriate legal advice. /hold |
|
@evankanderson sounds good. |
|
@vaikas-google I think we will need to at least update the autogen files with the new boilerplate, otherwise it seems that build-tests breaks. See Grant's comment |
|
I initially thought the build tests failed in #746 because the build test was verifying the boilerplate for all files, but that was my mistake: it's actually just verifying that generated code is current, and changing the boilerplate header changed the generated code. Based on @vaikas-google's and @evankanderson's comments above, I recommend closing this PR and opening a new one that only updates the boilerplate file and the generated code. While we're talking to counsel, we should ask them how to handle the copyright year on generated code. |
|
Closing this PR then |
Proposed Changes
Release Note