Skip to content

Refactor the code that rejects for wrong audience #7492

Merged
knative-prow[bot] merged 7 commits into
knative:mainfrom
Leo6Leo:Refactor-the-code-that-rejects-for-wrong-audience
Dec 14, 2023
Merged

Refactor the code that rejects for wrong audience #7492
knative-prow[bot] merged 7 commits into
knative:mainfrom
Leo6Leo:Refactor-the-code-that-rejects-for-wrong-audience

Conversation

@Leo6Leo
Copy link
Copy Markdown
Member

@Leo6Leo Leo6Leo commented Dec 6, 2023

Fixes #7487

Proposed Changes

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Docs

@Leo6Leo
Save Work progress
f6ec974 
Signed-off-by: Leo Li <leoli@redhat.com>
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Dec 6, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2023
@knative-prow knative-prow Bot requested review from lberk and odacremolbap December 6, 2023 07:23
@knative-prow knative-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 6, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 6, 2023 •
edited
Loading

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (1f38c2e) 76.12% compared to head (f8cb477) 76.15%.
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/auth/token_verifier.go 0.00% 15 Missing ⚠️
pkg/broker/filter/filter_handler.go 0.00% 5 Missing ⚠️
pkg/broker/ingress/ingress_handler.go 0.00% 3 Missing ⚠️
pkg/channel/event_receiver.go 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7492      +/-   ##
==========================================
+ Coverage   76.12%   76.15%   +0.02%     
==========================================
  Files         260      260              
  Lines       14467    14458       -9     
==========================================
- Hits        11013    11010       -3     
+ Misses       2888     2882       -6     
  Partials      566      566

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 12, 2023
@Leo6Leo Leo6Leo marked this pull request as ready for review December 12, 2023 05:55
@Leo6Leo Leo6Leo changed the title [WIP] Refactor the code that rejects for wrong audience Refactor the code that rejects for wrong audience Dec 12, 2023
@knative-prow knative-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2023
@knative-prow knative-prow Bot requested review from Cali0707 and aliok December 12, 2023 05:56
@Leo6Leo
Copy link
Copy Markdown
Member Author

Leo6Leo commented Dec 12, 2023

/cc @creydr

@knative-prow knative-prow Bot requested a review from creydr December 12, 2023 06:11
creydr
creydr reviewed Dec 12, 2023
View reviewed changes
Comment thread pkg/auth/utils.go Outdated
Comment thread pkg/broker/ingress/ingress_handler.go Outdated
@Leo6Leo
Pass the audience string pointer instead
e87690d 
Signed-off-by: Leo Li <leoli@redhat.com>
@Leo6Leo
Remove the redundant return
7ef6909 
Signed-off-by: Leo Li <leoli@redhat.com>
@knative-prow knative-prow Bot added the area/test-and-release Test infrastructure, tests or release label Dec 12, 2023
@Leo6Leo
Copy link
Copy Markdown
Member Author

Leo6Leo commented Dec 12, 2023

/cc @creydr

@knative-prow knative-prow Bot requested a review from creydr December 12, 2023 16:14
creydr
creydr requested changes Dec 13, 2023
View reviewed changes
Comment thread pkg/auth/utils.go Outdated
Comment thread test/auth/features/oidc/addressable_oidc_conformance.go
@Leo6Leo Leo6Leo requested a review from creydr December 14, 2023 06:36
creydr
creydr approved these changes Dec 14, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up @Leo6Leo

/lgtm

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2023
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Dec 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, Leo6Leo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2023
@knative-prow knative-prow Bot merged commit c38f800 into knative:main Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@creydr creydr creydr approved these changes

@lberk lberk Awaiting requested review from lberk

@odacremolbap odacremolbap Awaiting requested review from odacremolbap

@aliok aliok Awaiting requested review from aliok

@Cali0707 Cali0707 Awaiting requested review from Cali0707

Assignees

@creydr creydr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor the code that rejects for wrong audience

2 participants

@Leo6Leo @creydr