Cleanup created resources in channel conformance tests between features#7500
Merged
knative-prow[bot] merged 1 commit intoDec 8, 2023
Conversation
knative-prow
Bot
added
the
area/test-and-release
knative-prow
Bot
added
size/XS
Member
Author
|
@Cali0707 I think you might have run into the same in #7415 (comment) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7500 +/- ##
=======================================
Coverage 76.12% 76.12%
=======================================
Files 260 260
Lines 14467 14467
=======================================
Hits 11013 11013
Misses 2888 2888
Partials 566 566 ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
matzew
reviewed
Dec 8, 2023
| Should("Set the Channel status.deadLetterSinkURI if there is a valid spec.delivery.deadLetterSink defined", | ||
| readyChannelWithDLSHaveStatusUpdated(cName)) | ||
|
|
||
| f.Teardown("cleanup created resources", f.DeleteResources) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Channel conformance tests are running control- and data plane tests together in one test:
eventing/test/rekt/channel_test.go
Lines 59 to 60 in bdca23d
As both run in the same namespace and create resources without cleaning them up, this can lead to issues. E.g. as currently both use the same channel for their tests (
mychannelimpl). Then a control plane test creates a subscription for an existing channel. Later a data plane test runs and sends an event to the channel (mychannelimpl), but the channel still has a subscriber reference through the subscription from the control plane test. See for example knative-extensions/eventing-istio#158 (comment).This PR addresses it and adds a teardown to the features to clean their resources up, after the feature was tested.