[DO NOT MERGE] Test prow presubmit#77
Closed
adrcunha wants to merge 2 commits into
Closed
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
approved
Contributor
Author
|
/test pull-knative-eventing-integration-tests |
Contributor
Author
|
/hold |
google-prow-robot
added
the
do-not-merge/hold
Contributor
Author
|
/test all |
Contributor
Author
|
Required checks are now enforced. |
Closed
matzew
pushed a commit
to matzew/eventing
that referenced
this pull request
Apr 30, 2019
Broker rbac fixes
matzew
pushed a commit
to matzew/eventing
that referenced
this pull request
Feb 10, 2023
Whenever I set additional PingSource adapter env variables, the controller reverts my changes since it's doing a `DeepEqual` on env variables instead of doing `DeepDerivative(expected, current). Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.