make config snippet more readable#774
Merged
Merged
Conversation
knative-prow-robot
added
the
size/S
matzew
force-pushed
the
better_cfg_markdown
branch
from
8b7c3e9 to
fdadc97
Compare
Contributor
|
/lgtm I think this is clearly better. Will the sockpuppet keeping trying to change it back? |
n3wscott
reviewed
Jan 31, 2019
| `... apiVersion: v1 kind: ConfigMap metadata: name: kafka-channel-controller-config namespace: knative-eventing data: # Broker URL's for the provisioner bootstrap_servers: kafkabroker.kafka:9092 ...` > | ||
| Note: The `bootstrap_servers` needs to contain the address of at least one | ||
|
|
||
| ``` |
Contributor
There was a problem hiding this comment.
is there a ```yaml tag that can be used?
matzew
force-pushed
the
better_cfg_markdown
branch
from
fdadc97 to
101d4f1
Compare
Contributor
|
/lgtm |
Contributor
|
/lgtm |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
pierDipi
pushed a commit
to pierDipi/eventing
that referenced
this pull request
Sep 3, 2024
Co-authored-by: serverless-qe <serverless-support@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Harwayne I think that this commit:
968e82f#diff-b213c6bece8dad882117f26c39d41758L12
made the config part less readable.