Skip to content

Add an event source for k8sevents + function#79

Merged
google-prow-robot merged 2 commits into
knative:masterfrom
vaikas:k8s-events-source
Jun 11, 2018
Merged

Add an event source for k8sevents + function#79
google-prow-robot merged 2 commits into
knative:masterfrom
vaikas:k8s-events-source

Conversation

@vaikas
Copy link
Copy Markdown
Contributor

@vaikas vaikas commented Jun 8, 2018

Fixes Issue #

Proposed Changes

@google-prow-robot
Copy link
Copy Markdown

google-prow-robot commented Jun 8, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 8, 2018
@vaikas
Copy link
Copy Markdown
Contributor Author

vaikas commented Jun 9, 2018

/assign @scothis @grantr

scothis
scothis reviewed Jun 11, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@scothis scothis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a few places where it seems like docs for another service are leaking through.

I tried running the example, but didn't setup public DNS. I see events attempting to be delivered, but not making it (for obvious reasons)

Comment thread sample/k8s_events_function/README.md Outdated
Copy link
Copy Markdown
Contributor

@scothis scothis Jun 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't wait for the day we don't need valid public DNS to send events to a service inside the cluster... 🔜

Copy link
Copy Markdown
Contributor Author

@vaikas vaikas Jun 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) After this lands, I'll start working on wiring it to the bus.

Comment thread sample/k8s_events_function/bind.yaml Outdated
Copy link
Copy Markdown
Contributor

@scothis scothis Jun 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stale comment?

Copy link
Copy Markdown
Contributor Author

@vaikas vaikas Jun 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah. the object model is still a munging of parameter based configuration and specifying the full resource as a single string.

Comment thread sample/k8s_events_function/bind.yaml Outdated
Copy link
Copy Markdown
Contributor

@scothis scothis Jun 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is vaikas/misc?

Copy link
Copy Markdown
Contributor Author

@vaikas vaikas Jun 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a useless string, at least I now matched it with what it could look like.

Comment thread sample/k8s_events_function/README.md Outdated
Copy link
Copy Markdown
Contributor

@scothis scothis Jun 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is GCP PubSub used?

Copy link
Copy Markdown
Contributor Author

@vaikas vaikas Jun 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cut&paste error :(

@vaikas
Copy link
Copy Markdown
Contributor Author

vaikas commented Jun 11, 2018

Thanks for the review @scothis addressed the comments, PTAL :)

@scothis
Copy link
Copy Markdown
Contributor

scothis commented Jun 11, 2018

/lgtm

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2018
@google-prow-robot google-prow-robot merged commit 8c4a3af into knative:master Jun 11, 2018
@vaikas vaikas deleted the k8s-events-source branch June 12, 2018 02:28
scothis added a commit to scothis/eventing that referenced this pull request Sep 11, 2018
@scothis
Add scothis as an approver
f406ba0 
From [ROLES.MD](https://github.com/knative/docs/blob/dfc53c67c8e80d30b8863353c9e9b4ad00c41fa0/community/ROLES.md#approver):

> Reviewer of the codebase for at least 3 months or 50% of project lifetime, whichever is shorter

- [First Issue](knative#80). Opened 6/11
- [First PR](knative#66). Opened 5/31
- [First Review](knative#79 (review)) 6/11

> Primary reviewer for at least 10 substantial PRs to the codebase

- knative#422 (review)
- knative#414 (review)
- knative#325 (review)
- knative#225 (review)
- knative#189 (review)
- knative#168 (review)
- knative#165 (review)
- knative#99 (review)
- knative#79 (review)
- knative#111 (review)

> Reviewed or merged at least 30 PRs to the codebase

- [Reviewed 23 PRs](https://github.com/knative/eventing/pulls?utf8=✓&q=is%3Apr+reviewed-by%3Ascothis)
- [Authored 34 merged PRs](https://github.com/knative/eventing/pulls?utf8=✓&q=is%3Apr+author%3Ascothis+is%3Amerged)
- [Authored 5 open PRs](https://github.com/knative/eventing/pulls/scothis)

> Nominated by an area lead

From [WORKING_GROUPS.MD](https://github.com/knative/docs/blob/dfc53c67c8e80d30b8863353c9e9b4ad00c41fa0/community/WORKING-GROUPS.md#events)

/assign @vaikas-google

> With no objections from other leads

🤞

/cc @evankanderson @grantr @inlined @mattmoor
@scothis scothis mentioned this pull request Sep 11, 2018
Merged
knative-prow-robot pushed a commit that referenced this pull request Sep 12, 2018
@scothis @knative-prow-robot
Add scothis as an approver (#426)
396002a 
From [ROLES.MD](https://github.com/knative/docs/blob/dfc53c67c8e80d30b8863353c9e9b4ad00c41fa0/community/ROLES.md#approver):

> Reviewer of the codebase for at least 3 months or 50% of project lifetime, whichever is shorter

- [First Issue](#80). Opened 6/11
- [First PR](#66). Opened 5/31
- [First Review](#79 (review)) 6/11

> Primary reviewer for at least 10 substantial PRs to the codebase

- #422 (review)
- #414 (review)
- #325 (review)
- #225 (review)
- #189 (review)
- #168 (review)
- #165 (review)
- #99 (review)
- #79 (review)
- #111 (review)

> Reviewed or merged at least 30 PRs to the codebase

- [Reviewed 23 PRs](https://github.com/knative/eventing/pulls?utf8=✓&q=is%3Apr+reviewed-by%3Ascothis)
- [Authored 34 merged PRs](https://github.com/knative/eventing/pulls?utf8=✓&q=is%3Apr+author%3Ascothis+is%3Amerged)
- [Authored 5 open PRs](https://github.com/knative/eventing/pulls/scothis)

> Nominated by an area lead

From [WORKING_GROUPS.MD](https://github.com/knative/docs/blob/dfc53c67c8e80d30b8863353c9e9b4ad00c41fa0/community/WORKING-GROUPS.md#events)

/assign @vaikas-google

> With no objections from other leads

🤞

/cc @evankanderson @grantr @inlined @mattmoor
matzew pushed a commit to matzew/eventing that referenced this pull request Apr 11, 2019
@scothis @knative-prow-robot
Add scothis as an approver (knative#426)
dacf113 
From [ROLES.MD](https://github.com/knative/docs/blob/dfc53c67c8e80d30b8863353c9e9b4ad00c41fa0/community/ROLES.md#approver):

> Reviewer of the codebase for at least 3 months or 50% of project lifetime, whichever is shorter

- [First Issue](knative#80). Opened 6/11
- [First PR](knative#66). Opened 5/31
- [First Review](knative#79 (review)) 6/11

> Primary reviewer for at least 10 substantial PRs to the codebase

- knative#422 (review)
- knative#414 (review)
- knative#325 (review)
- knative#225 (review)
- knative#189 (review)
- knative#168 (review)
- knative#165 (review)
- knative#99 (review)
- knative#79 (review)
- knative#111 (review)

> Reviewed or merged at least 30 PRs to the codebase

- [Reviewed 23 PRs](https://github.com/knative/eventing/pulls?utf8=✓&q=is%3Apr+reviewed-by%3Ascothis)
- [Authored 34 merged PRs](https://github.com/knative/eventing/pulls?utf8=✓&q=is%3Apr+author%3Ascothis+is%3Amerged)
- [Authored 5 open PRs](https://github.com/knative/eventing/pulls/scothis)

> Nominated by an area lead

From [WORKING_GROUPS.MD](https://github.com/knative/docs/blob/dfc53c67c8e80d30b8863353c9e9b4ad00c41fa0/community/WORKING-GROUPS.md#events)

/assign @vaikas-google

> With no objections from other leads

🤞

/cc @evankanderson @grantr @inlined @mattmoor
matzew added a commit to matzew/eventing that referenced this pull request May 2, 2019
@matzew
Merge pull request knative#79 from matzew/upates_to_master
aa1e03c 
syncing latest files w/ openshift master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@scothis scothis scothis left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@grantr grantr

@scothis scothis

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vaikas @google-prow-robot @scothis @grantr