CrossNamespace: e2e test to verify event delivery for broker and trigger by yijie-04 · Pull Request #7933 · knative/eventing

yijie-04 · 2024-05-22T16:09:08Z

Fixes #7927

Proposed Changes

We should have an e2e test to verify that event delivery for broker and trigger when they are in different namespaces.

🎁 Add new feature

Pre-review Checklist

At least 80% unit test coverage
E2E tests for any new behavior
Docs PR for any user-facing impact
Spec PR for any new API feature
Conformance test for any change to the spec

Release Note

Docs

…r_data_plane

yijie-04 · 2024-05-22T16:10:28Z

/cc @Cali0707 @pierDipi

pierDipi

A different test structure could be to create 2 environments so that you don't need to create your namespaces

	brokerEnvCtx, brokerEnv := global.Environment(
		knative.WithKnativeNamespace(system.Namespace()),
		knative.WithLoggingConfig,
		knative.WithTracingConfig,
		k8s.WithEventListener,
		environment.Managed(t),
	)

	triggerEnvCtx, triggerEnv := global.Environment(
		knative.WithKnativeNamespace(system.Namespace()),
		knative.WithLoggingConfig,
		knative.WithTracingConfig,
		k8s.WithEventListener,
		environment.Managed(t),
	)

        brokerEnv.Test(brokerEnvCtx, t, broker.GoesReady(...))
        triggerEnv.Test(triggerEnvCtx, t, trigger.CrossNamespaceEventLink(brokerEnvCtx, ...))

codecov · 2024-05-23T18:48:06Z

Codecov Report

Attention: Patch coverage is 22.22222% with 35 lines in your changes missing coverage. Please review.

Project coverage is 67.80%. Comparing base (9eed163) to head (e440cb1).
Report is 1 commits behind head on main.

Files	Patch %	Lines
pkg/broker/filter/filter_handler.go	8.82%	30 Missing and 1 partial ⚠️
pkg/reconciler/broker/trigger/controller.go	50.00%	1 Missing and 2 partials ⚠️
pkg/reconciler/sugar/trigger/controller.go	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7933      +/-   ##
==========================================
- Coverage   67.85%   67.80%   -0.05%     
==========================================
  Files         367      367              
  Lines       17356    17377      +21     
==========================================
+ Hits        11777    11783       +6     
- Misses       4844     4859      +15     
  Partials      735      735

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pierDipi · 2024-05-27T13:04:39Z

/test reconciler-tests

Cali0707 · 2024-07-05T12:06:52Z

/test reconciler-tests

Cali0707 · 2024-07-05T12:07:27Z

@yijie-04 can you rebase this PR?

Cali0707

/lgtm

knative-prow · 2024-07-05T14:04:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, yijie-04

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Cali0707]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

yijie-04 · 2024-07-05T14:57:02Z

/test reconciler-tests

Signed-off-by: Calum Murray <cmurray@redhat.com>

Cali0707 · 2024-07-05T16:49:03Z

/cc @Leo6Leo

Can you TAL? I've added a decent amount of my code to this PR so it would be good to get the final LGTM from someone else

yijie-04 · 2024-07-05T16:51:33Z

@Cali0707 I think there are also some tab/space issues for the license

Cali0707

These should fix the license issues

Co-authored-by: Calum Murray <cmurray@redhat.com>

Leo6Leo

Only one nit, otherwise, it looks great to me!

Cali0707 · 2024-07-09T16:25:26Z

/retest

yijie-04 · 2024-07-09T16:25:27Z

/test reconciler-tests

yijie-04 · 2024-07-09T16:32:54Z

/retest

Leo6Leo · 2024-07-09T17:33:19Z

/lgtm

yijie-04 added 8 commits May 9, 2024 23:51

data plane changes

49aa6bc

Merge branch 'main' of https://github.com/knative/eventing into broke…

9a4b65f

…r_data_plane

moved global variables inside function

ba4d1e5

updated other functions

d164904

feature flag

f1f37b3

verifying events get delivered

5d7cf6b

main test

1e5a8de

test for broker in different namespace

2c76de4

knative-prow Bot added area/test-and-release Test infrastructure, tests or release size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 22, 2024

knative-prow Bot requested review from mgencur and odacremolbap May 22, 2024 16:09

Merge branch 'main' of https://github.com/knative/eventing into e2e_test

384d975

knative-prow Bot requested review from Cali0707 and pierDipi May 22, 2024 16:10

yijie-04 changed the title ~~CrossNamespace: e2e test to verify event delivery for broker and trigger~~ [WIP] CrossNamespace: e2e test to verify event delivery for broker and trigger May 22, 2024

knative-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 22, 2024

pierDipi reviewed May 23, 2024

View reviewed changes

yijie-04 added 4 commits May 23, 2024 12:13

changed to two environments

f8a08b0

updated namespace variables

2d6913c

moved feature flag prerequisite

911471b

fix global undefined problem

1265d25

pierDipi reviewed May 27, 2024

View reviewed changes

Comment thread test/rekt/features/trigger/crossnamespace.go Outdated

yijie-04 added 3 commits May 28, 2024 11:35

updated creating namespace

0350342

ctx variable name update

d1e876b

getting rid of trigger goes ready since it's done in feature

1c21962

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2024

Merge remote-tracking branch 'upstream/main' into e2e_test

3398839

knative-prow Bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2024

knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2024

Cali0707 approved these changes Jul 5, 2024

View reviewed changes

knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2024

fix: feature flags are passed correctly (#2)

e3b8645

Signed-off-by: Calum Murray <cmurray@redhat.com>

knative-prow Bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2024

Cali0707 reviewed Jul 5, 2024

View reviewed changes

Comment thread test/rekt/crossnamespace_test.go Outdated

Comment thread test/rekt/features/broker/crossnamespace.go Outdated

Comment thread test/rekt/features/trigger/crossnamespace.go Outdated

knative-prow Bot requested a review from Leo6Leo July 5, 2024 17:45

yijie-04 and others added 3 commits July 5, 2024 14:18

Update test/rekt/crossnamespace_test.go

c18c5df

Co-authored-by: Calum Murray <cmurray@redhat.com>

Update test/rekt/features/broker/crossnamespace.go

49528fb

Co-authored-by: Calum Murray <cmurray@redhat.com>

Update test/rekt/features/trigger/crossnamespace.go

6e03cd5

Co-authored-by: Calum Murray <cmurray@redhat.com>

Leo6Leo reviewed Jul 9, 2024

View reviewed changes

Comment thread test/rekt/resources/trigger/trigger.go Outdated

yijie-04 added 2 commits July 9, 2024 10:53

cleaned up comments

7edd6f2

Merge remote-tracking branch 'upstream/main' into e2e_test

e440cb1

knative-prow Bot assigned Leo6Leo Jul 9, 2024

knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2024

knative-prow Bot merged commit 8e7c775 into knative:main Jul 9, 2024

yijie-04 deleted the e2e_test branch July 9, 2024 18:41

Conversation

yijie-04 commented May 22, 2024 • edited by pierDipi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Pre-review Checklist

Uh oh!

yijie-04 commented May 22, 2024

Uh oh!

pierDipi left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented May 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pierDipi commented May 27, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Cali0707 commented Jul 5, 2024

Uh oh!

Cali0707 commented Jul 5, 2024

Uh oh!

Cali0707 left a comment

Choose a reason for hiding this comment

Uh oh!

knative-prow Bot commented Jul 5, 2024

Uh oh!

yijie-04 commented Jul 5, 2024

Uh oh!

Cali0707 commented Jul 5, 2024

Uh oh!

yijie-04 commented Jul 5, 2024

Uh oh!

Cali0707 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Leo6Leo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Cali0707 commented Jul 9, 2024

Uh oh!

yijie-04 commented Jul 9, 2024

Uh oh!

yijie-04 commented Jul 9, 2024

Uh oh!

Leo6Leo commented Jul 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

yijie-04 commented May 22, 2024 •

edited by pierDipi

Loading

pierDipi left a comment •

edited

Loading

codecov Bot commented May 23, 2024 •

edited

Loading