Skip to content

Add namespace labels to source metrics#8892

Merged
knative-prow[bot] merged 1 commit into
knative:mainfrom
creydr:add-namespace-and-sourcename-to-apiserversource-and-pingsource-metrics
Mar 3, 2026
Merged

Add namespace labels to source metrics#8892
knative-prow[bot] merged 1 commit into
knative:mainfrom
creydr:add-namespace-and-sourcename-to-apiserversource-and-pingsource-metrics

Conversation

@creydr
Copy link
Copy Markdown
Member

@creydr creydr commented Mar 3, 2026

Adding the namespace and source name tags to the metrics of the ApiServerSource and PingSource

@creydr creydr requested a review from Cali0707 March 3, 2026 16:44
@knative-prow knative-prow Bot requested review from aslom and matzew March 3, 2026 16:44
@knative-prow knative-prow Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 3, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 68.96552% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.65%. Comparing base (223b43f) to head (73b7e01).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/observability/newcontext.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8892      +/-   ##
==========================================
+ Coverage   50.62%   50.65%   +0.02%     
==========================================
  Files         409      409              
  Lines       21657    21680      +23     
==========================================
+ Hits        10963    10981      +18     
- Misses       9839     9846       +7     
+ Partials      855      853       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Cali0707
Copy link
Copy Markdown
Member

Cali0707 commented Mar 3, 2026

/test reconciler-tests

Copy link
Copy Markdown
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks @creydr !

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Mar 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot merged commit ba8ac76 into knative:main Mar 3, 2026
37 checks passed
creydr added a commit to creydr/knative-eventing that referenced this pull request Mar 4, 2026
openshift-merge-bot Bot pushed a commit to openshift-knative/eventing that referenced this pull request Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants