Skip to content

Remove markdown lint presubmit check in favor of the sockpuppet.#907

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
evankanderson:a-pile-of-yaks
Mar 14, 2019
Merged

Remove markdown lint presubmit check in favor of the sockpuppet.#907
knative-prow-robot merged 1 commit into
knative:masterfrom
evankanderson:a-pile-of-yaks

Conversation

@evankanderson
Copy link
Copy Markdown
Member

Proposed Changes

  • Removes markdown linting in favor of the sockpuppet. Record the decision on Broker and Trigger #862 has hard tabs in the go code (as is appropriate for go code) referenced in the markdown file. prettier.io is fine with this and formats correctly. The linter does not. I see three ways forward:
    • Replace tabs with spaces in the go code, requiring reformatting it when copy-pasting.
    • Add MD10 to the set of exceptions, allowing a mix of tabs and spaces everywhere in markdown.
    • Remove the linter that randomly breaks submits, where the error reporting is not clear about the problem, and adds extra human toil to comply (vs sockpuppet, which just adds toil to approve the fixups, which are very easy to review).

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 14, 2019
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 14, 2019
@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Mar 14, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2019
@grantr
Copy link
Copy Markdown
Contributor

grantr commented Mar 14, 2019

/approve x 💯

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, grantr, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 56a83f8 into knative:master Mar 14, 2019
creydr pushed a commit to creydr/knative-eventing that referenced this pull request Oct 31, 2024
Co-authored-by: serverless-qe <serverless-support@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants