Skip to content

Switch the Broker's Ingress to use CloudEvents SDK#933

Merged
knative-prow-robot merged 180 commits into
knative:masterfrom
Harwayne:ingress-cloudevents
Mar 21, 2019
Merged

Switch the Broker's Ingress to use CloudEvents SDK#933
knative-prow-robot merged 180 commits into
knative:masterfrom
Harwayne:ingress-cloudevents

Conversation

@Harwayne
Copy link
Copy Markdown
Contributor

@Harwayne Harwayne commented Mar 20, 2019 •
edited
Loading

Helps with #891.

Proposed Changes

  • Switch the Broker's Ingress to use CloudEvents SDK.

Release Note

NONE

Harwayne and others added 30 commits January 28, 2019 09:13
@Harwayne
Initial API outline for Broker.
d7ed39b
@Harwayne
Metadata is exported
080f5eb
@Harwayne
Initial Trigger API.
f20a2df
@Harwayne
Remove old comments.
163474d
@Harwayne
Register the types.
5f53e05
@Harwayne
Initial work on the Broker controller.
2f6a03f
@Harwayne
Initial work on the Trigger controller.
3ee0b8b
@Harwayne
Initial work on the new model and its corresponding broker controller.
da9fe36
@Harwayne
Initial work on the Trigger controller.
f8cca2e
@Harwayne
Add simple mains.
d7ebdcb
@Harwayne
Small fixes, still not working.
c5f7a83
@Harwayne
Add the Istio injection annotation.
054c10d
@Harwayne
Resolve subscriber in the Trigger controller.
942b979
@Harwayne
Standardize on 'Any'.
afd71af
@Harwayne
Make Broker and Trigger generational
7a1f69b
@Harwayne
Happy control path.
2be56bd
@Harwayne
TargetPort is 8080
10acfa3
@Harwayne
Watch channels.
2108d83
@Harwayne
Custom service account for filter (needs trigger watch).
6aa7086
@Harwayne
Increase logging in the Filter to debug level.
3cd236f
@Harwayne
Use the default channel provisioner.
be350a0
@nachocano
Adding filtering using k8s label selectors
0068232
@Harwayne
Watch namespaces and create a default Broker.
b4e2358
@nachocano
Merge remote-tracking branch 'broker/broker-new-model' into broker-ne…
3a9fd94 
…w-model
@nachocano
Updating trigger example with filters
5ca1b9f
@Harwayne
Broker changes cause the namespace watcher to reconcile.
bd53cda
@nachocano
Merge remote-tracking branch 'broker/broker-new-model' into broker-ne…
17889fb 
…w-model
@Harwayne
Merge branch 'master' into broker-new-model
582eb4c
@Harwayne
Move the Logging package import and format.
4f803a2
@nachocano
Updating after review comments. Only doing exact header matching.
eec0f8d 
In a follow up PR, I plan to include matching of expressions. It turns
our that they are somewhat more involved than expected.
@knative-prow-robot knative-prow-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 20, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 20, 2019
@Harwayne Harwayne force-pushed the ingress-cloudevents branch from 99eb13f to 790c44e Compare March 20, 2019 20:10
@Harwayne Harwayne force-pushed the ingress-cloudevents branch from dabe9b4 to 158ea91 Compare March 20, 2019 20:35
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 21, 2019
@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Mar 21, 2019

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/broker/context.go Do not exist 100.0%
pkg/broker/receiver.go 74.0% 82.7% 8.8

@Harwayne Harwayne changed the title [WIP] Switch the Broker's Ingress to use CloudEvents SDK Switch the Broker's Ingress to use CloudEvents SDK Mar 21, 2019
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2019
@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Mar 21, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Mar 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Harwayne,vaikas-google]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit b1767a0 into knative:master Mar 21, 2019
@Harwayne Harwayne deleted the ingress-cloudevents branch March 25, 2019 21:17
cardil added a commit to cardil/knative-eventing that referenced this pull request Oct 30, 2020
@cardil
Embedding configuration structs (knative#933)
5472d92 
Conflicts resolved:
 * test/upgrade/prober/configuration.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grantr grantr Awaiting requested review from grantr

@n3wscott n3wscott Awaiting requested review from n3wscott

Assignees

@vaikas vaikas

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Harwayne @knative-metrics-robot @vaikas @knative-prow-robot @googlebot @nachocano @grantr