Skip to content

Create subscriber.uri and deprecate subscriber.dnsName#994

Merged
knative-prow-robot merged 2 commits into
knative:masterfrom
Harwayne:sub-uri
Mar 28, 2019
Merged

Create subscriber.uri and deprecate subscriber.dnsName#994
knative-prow-robot merged 2 commits into
knative:masterfrom
Harwayne:sub-uri

Conversation

@Harwayne
Copy link
Copy Markdown
Contributor

@Harwayne Harwayne commented Mar 28, 2019

Fixes #991

Proposed Changes

  • Create subscriber.uri and deprecate subscriber.dnsName.
    • The fields have identical semantics, both are used as a URI. We are simply giving the field the proper name.
  • [BUG] Remove the deprecrated subscriber.dnsName #993 - In the following release, we will remove the deprecated subscriber.dnsName field.

Release Note

Switch from using subscriber.dnsName to subscriber.uri. subscriber.dnsName will be removed in the next release.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 28, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Mar 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 28, 2019
matzew
matzew reviewed Mar 28, 2019
View reviewed changes
Comment thread pkg/apis/eventing/v1alpha1/subscription_types.go
// http://myexternalhandler.example.com/foo/bar
// +optional
DNSName *string `json:"dnsName,omitempty"`
DeprecatedDNSName *string `json:"dnsName,omitempty"`
Copy link
Copy Markdown
Member

@matzew matzew Mar 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when will it be removed? the DeprecatedDNSName ?

Copy link
Copy Markdown
Contributor Author

@Harwayne Harwayne Mar 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#993 tracks removing it. The plan is to leave it deprecated for one release. Then remove it in the next. So if this PR merges into 0.5.0, we would remove it in 0.6.0.

matzew
matzew reviewed Mar 28, 2019
View reviewed changes
Comment thread pkg/apis/eventing/v1alpha1/subscription_validation.go
fieldsSet = append(fieldsSet, "ref")
}
if s.DeprecatedDNSName != nil && *s.DeprecatedDNSName != "" {
fieldsSet = append(fieldsSet, "dnsName")
Copy link
Copy Markdown
Member

@matzew matzew Mar 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it populate the uri ?

Copy link
Copy Markdown
Contributor Author

@Harwayne Harwayne Mar 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My hesitation for doing that is code like our Trigger controller, which will compare the spec, if it differs, it will delete the Subscription and create a new one. Our Trigger controller wouldn't hit that problem because it uses ref, not dnsName, but I could see a similar controller hitting the problem.

What do you think? Is it worth the potential trouble to move things for the user?

Copy link
Copy Markdown
Member

@matzew matzew Mar 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, fair point w/ the Trigger controller.

So, no need to "adjust" it

@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Mar 28, 2019

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/eventing/v1alpha1/subscription_validation.go 100.0% 98.5% -1.5

@matzew
Copy link
Copy Markdown
Member

matzew commented Mar 28, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2019
@knative-prow-robot knative-prow-robot merged commit ceeff41 into knative:master Mar 28, 2019
Harwayne added a commit to Harwayne/knative-eventing that referenced this pull request Mar 28, 2019
@Harwayne
Add subscriber.uri to Trigger's OpenAPI schema, to match knative#994.
f5b2080
@Harwayne Harwayne mentioned this pull request Mar 28, 2019
Merged
knative-prow-robot pushed a commit that referenced this pull request Mar 29, 2019
@Harwayne @knative-prow-robot
Add subscriber.uri to Trigger's OpenAPI schema, to match #994. (#999)
70a0440
@matzew matzew mentioned this pull request Oct 10, 2019
Merged
pierDipi pushed a commit to pierDipi/eventing that referenced this pull request Jan 30, 2025
@creydr
Merge pull request knative#994 from creydr/bump-golang-x-net-v1.16
8e55405 
[release-v1.16] Update golang.org/x/net to 0.34.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew matzew left review comments

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@matzew matzew

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Harwayne @knative-prow-robot @knative-metrics-robot @matzew @googlebot