Cleanup: Remove container flag & make the builder dynamic (var II)#2983
Closed
gauron99 wants to merge 1 commit intoknative:mainfrom
Closed
Cleanup: Remove container flag & make the builder dynamic (var II)#2983gauron99 wants to merge 1 commit intoknative:mainfrom
gauron99 wants to merge 1 commit intoknative:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2983 +/- ##
==========================================
+ Coverage 58.95% 59.68% +0.72%
==========================================
Files 132 132
Lines 16944 16936 -8
==========================================
+ Hits 9990 10108 +118
+ Misses 6025 5866 -159
- Partials 929 962 +33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1defaea to
859bcf7
Compare
859bcf7 to
00006c2
Compare
00006c2 to
f1faf6b
Compare
f1faf6b to
4ca5896
Compare
Contributor
Author
|
Closing this in favor of variant I #2987 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variant II
Changes
--containerflagruncmd uses the current builderhostbuilder as default (not only for run) if runtime supports it, otherwisepack/kind cleanup
Fixes #2973
Release Note
Docs