Skip to content

bug: bug: python injector needs the invoke default #2994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow merged 1 commit into from
Aug 20, 2025
Merged

bug: bug: python injector needs the invoke default #2994

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion pkg/builders/buildpacks/builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,14 @@ func (b *Builder) Build(ctx context.Context, f fn.Function, platforms []fn.Platf

if f.Runtime == "python" {
if fi, _ := os.Lstat(filepath.Join(f.Root, "Procfile")); fi == nil {
cli = pyScaffoldInjector{cli, f.Invoke}
// HACK (of a hack): need to get the right invocation signature
// the standard scaffolding does this in toSignature() func.
// we know we have python here.
invoke := f.Invoke
if invoke == "" {
invoke = "http"
}
cli = pyScaffoldInjector{cli, invoke}
}
}

Expand Down
Loading