Skip to content

test: skip ipv6 test correctly #3076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow merged 1 commit into from
Oct 13, 2025
Merged

test: skip ipv6 test correctly #3076

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions pkg/ssh/ssh_dialer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ type testParams struct {
setUpEnv setUpEnvFn
skipOnWin bool
skipOnRoot bool
requireIPv6 bool
CreateError string
DialError string
}
Expand Down Expand Up @@ -192,7 +193,8 @@ func TestCreateDialer(t *testing.T) {
connConfig.hostIPv6,
connConfig.portIPv6,
)},
setUpEnv: all(withoutSSHAgent, withCleanHome, withKnowHosts(connConfig)),
requireIPv6: true,
setUpEnv: all(withoutSSHAgent, withCleanHome, withKnowHosts(connConfig)),
},
{
name: "broken known host",
Expand Down Expand Up @@ -361,13 +363,13 @@ func TestCreateDialer(t *testing.T) {

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
u, err := url.Parse(tt.args.connStr)
th.AssertNil(t, err)

if net.ParseIP(u.Hostname()).To4() == nil && connConfig.hostIPv6 == "" {
if tt.requireIPv6 && connConfig.hostIPv6 == "" {
t.Skip("skipping ipv6 test since test environment doesn't support ipv6 connection")
}

u, err := url.Parse(tt.args.connStr)
th.AssertNil(t, err)

if tt.skipOnWin && runtime.GOOS == "windows" {
t.Skip("skipping this test on windows")
}
Expand Down
Loading