Adding "knative-gcp/test/conflict/" to the caller whitelist for package shell

[cathyzhyi]

I am trying to add an e2e test to detect knative-gcp overwriting other installed components google/knative-gcp#1995. This reads the output of ko apply and look for the word configured. It would be convenient if I can use the shell package.

Is it OK to just add the path to

hack/shell/project.go

Line 68 in d946d25

validPaths := []string{

or are there any suggestions on how I should do this?

[cathyzhyi]

@cardil Hey Chris, do you have any suggestion about this?

[cardil]

@n3wscott @vaikas As you can see this code has gated usage of shell scripting from other places.

hack/shell/project.go

Lines 68 to 71 in d946d25

	validPaths := []string{
	"knative.+/test/upgrade/",
	"knative(:?\\.dev/|-)hack/shell/",
	}

But, the question remains. We should not allow over usage of this shell out function. I see there couple solutions:

• Allow adding additional places to use shell out package - this is dangerous as we explicitly didn't want that to grow, but decline from being used
• Advice forking knative/hack repo, and use forked modified one, if shell out is required.
• Advice to not use shell outs at all, but rather implement those operations in Golang

I feel like the last one is most reasonable, but on the other hand will require the most work.

[n3wscott]

I am ok adding another allow usage entry, but understand it will be replaced on a shortish timeline. @cathyzhyi would you like to make a PR to add that?

[cathyzhyi]

@n3wscott @cardil Thanks for the suggestions! Just to make sure I understand the best way forward correctly. It's ok to add another usage entry but we should move to option 3 not use shell outs at all, but rather implement those operations in Golang asap right?

[krsna-m]

Doing a little manual cleanup. If this is still an issue please reopen this issue.