Add HTTPS port variables#640
Merged
Merged
Conversation
This patch adds HTTPS port variables.
Codecov Report
@@ Coverage Diff @@
## main #640 +/- ##
=======================================
Coverage 94.56% 94.56%
=======================================
Files 38 38
Lines 810 810
=======================================
Hits 766 766
Misses 31 31
Partials 13 13
Continue to review full report at Codecov.
|
7 tasks
Contributor
Author
|
knative/serving#12770 is the code to demonstrate how to use this variables. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nak3, ZhiminXiang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds HTTPS port variables.
Part of knative/serving#12501.
/cc @evankanderson @ZhiminXiang @carlisia