Skip to content

Add docs on the configuration of operator CRs#18

Closed
houshengbo wants to merge 3 commits intoknative:masterfrom
houshengbo:add-doc-configuration
Closed

Add docs on the configuration of operator CRs#18
houshengbo wants to merge 3 commits intoknative:masterfrom
houshengbo:add-doc-configuration

Conversation

@houshengbo
Copy link
Copy Markdown

@houshengbo houshengbo commented Apr 16, 2020 •
edited
Loading

Fixes #

Proposed Changes

Release Note

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Apr 16, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2020
@googlebot
Copy link
Copy Markdown

googlebot commented Apr 16, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Indicates the PR's author has not signed the CLA. label Apr 16, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 16, 2020
knative-prow-robot
knative-prow-robot reviewed Apr 16, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houshengbo: 0 warnings.

Details

In response to this:

Fixes #

Proposed Changes

Release Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@houshengbo houshengbo force-pushed the add-doc-configuration branch from 4d1f43f to de4b628 Compare April 16, 2020 18:31
@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 16, 2020
@houshengbo houshengbo force-pushed the add-doc-configuration branch from de4b628 to ffaf9e7 Compare April 16, 2020 18:32
@googlebot
Copy link
Copy Markdown

googlebot commented Apr 16, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Apr 16, 2020
@houshengbo houshengbo changed the title Add doc configuration Add docs on the configuration of operator CRs Apr 16, 2020
@aliok
Copy link
Copy Markdown
Member

aliok commented Apr 17, 2020

Let's ping @abrennan89 in case she might be interested in having a look

@aliok
Copy link
Copy Markdown
Member

aliok commented Apr 17, 2020

/assign @aliok

I will go through these documents and try the instructions

@aliok
Copy link
Copy Markdown
Member

aliok commented Apr 17, 2020

/unassign @aliok

Just read the Slack messages about this PR: https://knative.slack.com/archives/CEPGNPHP1/p1587060729331500

Leaving it to @evankanderson and @jcrossley3 as I think there will be some reconciliation.
I can help with the technical verification, guys.

@houshengbo houshengbo closed this Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@Cynocracy Cynocracy Awaiting requested review from Cynocracy

@trshafer trshafer Awaiting requested review from trshafer

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@houshengbo @knative-prow-robot @googlebot @aliok