apis.Convertible has confusing function names

[dprotaso]

What ConvertUp & ConvertDown should do isn't immediately obvious.

pkg/apis/interfaces.go

Lines 37 to 45 in 79f1045

	// Convertible indicates that a particular type supports conversions to/from
	// "higher" versions of the same type.
	type Convertible interface {
	// ConvertUp up-converts the receiver into `to`.
	ConvertUp(ctx context.Context, to Convertible) error
	// ConvertDown down-converts from `from` into the receiver.
	ConvertDown(ctx context.Context, from Convertible) error
	}

Suggested Alternative

• ConvertTo & ConvertFrom

[dprotaso]

cc @mattmoor @vaikas @n3wscott @vagababov

[mattmoor]

I think my original suggestion was UpFrom and DownTo. I agree that including a qualifier to indicate the asymmetry would be useful.

mattmoor/serving@a1a18f7#diff-f9e008c1b737ef87f37530e188421665R136

[n3wscott]

+1 on xFrom and xTo

I like ConvertTo & ConvertFrom because it reads to me as it is doing a conversion. I understand this, I understand UpFrom less

[vaikas]

+1 was super confusing and had to go digging and read with care :) make it so.

[n3wscott]

ConvertUpTo and ConvertDownTo

[dprotaso]

Are we ok with a breaking change?

…

On Thu, Feb 6, 2020 at 1:10 PM Scott Nichols ***@***.***> wrote: ConvertUpTo and ConvertDownTo — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1057?email_source=notifications&email_token=AAAERAX7SNGXYO4EDXGY4A3RBRHBTA5CNFSM4KQ6AOJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELAG6JY#issuecomment-583036711>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAERAWKZW66HGTUMGYBFOLRBRHBTANCNFSM4KQ6AOJQ> .

[vagababov]

I can go with ConvertUp/DownTo.
We can do two step wherein we have both names for 2 releases.

[dgerd]

+1 on ConvertTo and ConvertFrom. I am not sure it is worth a change if we are just adding To to the end of the existing functions.

I am okay with a breaking change here, but we should have the fixed dependencies ready with [WIP] PRs before checking this into pkg to limit time of breakage.