RFE: func WaitForXXXX should print last state of the resource when failed

[nak3]

/area test-and-release

When func WaitForXXXX in test/kube_checks.go failed, it just prints the error as timed out waiting for the condition.

(e.g.) autoscale_test.go

    autoscale_test.go:231: Unable to observe the Deployment named autoscale-up-down-up-tvuqkpaq-bjqz2-deployment scaling down: timed out waiting for the condition

So, it is still difficult to know why it fails. It would be useful if we can get the last state of the resource.

Actually serving project implements it in WaitForConfigurationState() for their resources as:

https://github.com/knative/serving/blob/4505ff00396d4acd85cd079ce7f20d815927d157/test/v1beta1/configuration.go#L119-L137

so test/kube_checks.go could be changed as same manner.

[MIBc]

I'd like to try.

[nak3]

Sure. I would highly appreciate if you could take it. But I'm still not sure if this idea will be accepted or not.

[github-actions]

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

[vagababov]

/good-first-issue
/lifecycle frozen
I find this a useful improvement for test debuggability.

[knative-prow-robot]

@vagababov:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

Details

In response to this:

/good-first-issue
/lifecycle frozen
I find this a useful improvement for test debuggability.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[skonto]

I can do it if no one else is interested.

[skonto]

/assign