Skip to content

add retry func for reconciler#1008

Merged
knative-prow-robot merged 4 commits intoknative:masterfrom
nlopezgi:addRetryFunc
Jan 27, 2020
Merged

add retry func for reconciler#1008
knative-prow-robot merged 4 commits intoknative:masterfrom
nlopezgi:addRetryFunc

Conversation

@nlopezgi
Copy link
Copy Markdown
Contributor

@nlopezgi nlopezgi commented Jan 23, 2020

knative/serving#6162 added a retry mechanism for status updates that will be of use for:

fyi @nachocano

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 23, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 23, 2020
@nlopezgi nlopezgi mentioned this pull request Jan 23, 2020
Merged
@nlopezgi nlopezgi force-pushed the addRetryFunc branch 2 times, most recently from 3832ac6 to 983d2fb Compare January 23, 2020 21:12
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 23, 2020
@nlopezgi
Copy link
Copy Markdown
Contributor Author

nlopezgi commented Jan 23, 2020

PR was failing on presubmit complaining I need to run ./hack/update-codegen.sh. Had to also run update-deps which added tons of files to vendor directory. Not too experienced with go, so not sure this should be expected of this PR.

@vagababov
Copy link
Copy Markdown
Contributor

vagababov commented Jan 23, 2020

Yes you need to run those, to prune the redundant files.
your chage should be 1-2 files at most.

@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 24, 2020
@nlopezgi
Copy link
Copy Markdown
Contributor Author

nlopezgi commented Jan 24, 2020

Yes you need to run those, to prune the redundant files.
your chage should be 1-2 files at most.

Thanks, I think I got it to run properly this time. Please let me know if this looks good. Thanks!

dgerd
dgerd reviewed Jan 24, 2020
View reviewed changes
Comment thread reconciler/retry_test.go
@dgerd
Copy link
Copy Markdown

dgerd commented Jan 24, 2020

/assign @mattmoor
as I don't have approval powers here.

vagababov
vagababov reviewed Jan 24, 2020
View reviewed changes
Comment thread reconciler/retry.go Outdated
@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Jan 25, 2020

The following is the coverage report on the affected files.
Say /test pull-knative-pkg-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
reconciler/retry.go Do not exist 100.0%

@vagababov
Copy link
Copy Markdown
Contributor

vagababov commented Jan 25, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2020
@vagababov
Copy link
Copy Markdown
Contributor

vagababov commented Jan 25, 2020

/lgtm
/approve

@nlopezgi
Copy link
Copy Markdown
Contributor Author

nlopezgi commented Jan 27, 2020

@mattmoor this is ready to go; or let me know if there are any pending changes, thanks!

@mattmoor
Copy link
Copy Markdown
Member

mattmoor commented Jan 27, 2020

/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jan 27, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, nlopezgi, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2020
@knative-prow-robot knative-prow-robot merged commit 4252f59 into knative:master Jan 27, 2020
@nlopezgi nlopezgi deleted the addRetryFunc branch January 27, 2020 15:22
This was referenced Jan 28, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@vagababov vagababov vagababov left review comments

@mattmoor mattmoor mattmoor left review comments

@dgerd dgerd dgerd left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@vagababov vagababov

@mattmoor mattmoor

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nlopezgi @vagababov @dgerd @knative-metrics-robot @mattmoor @knative-prow-robot @googlebot