Skip to content

Fix crash looping when leader election config doesn't exist (#1142)#1143

Merged
knative-prow-robot merged 1 commit into
knative:release-0.13from
pmorie:le-missing-cfg-cp
Mar 5, 2020
Merged

Fix crash looping when leader election config doesn't exist (#1142)#1143
knative-prow-robot merged 1 commit into
knative:release-0.13from
pmorie:le-missing-cfg-cp

Conversation

@pmorie
Copy link
Copy Markdown
Contributor

@pmorie pmorie commented Mar 5, 2020

Cherry-pick of #1142

@googlebot
Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Indicates the PR's author has not signed the CLA. label Mar 5, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 5, 2020
Copy link
Copy Markdown
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2020
@evankanderson
Copy link
Copy Markdown
Member

@googlebot wtf

/lgtm
/approve

I'm guessing that this is how we want to pull this pkg change forward into the 0.13 release branches in other repos.

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, pmorie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2020
@vagababov
Copy link
Copy Markdown
Contributor

/check-cla

@evankanderson evankanderson added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Mar 5, 2020
@googlebot googlebot removed the cla: yes Indicates the PR's author has signed the CLA. label Mar 5, 2020
@googlebot
Copy link
Copy Markdown

☹️ Sorry, but only Googlers may change the label cla: yes.

@isdal isdal added the cla: yes Indicates the PR's author has signed the CLA. label Mar 5, 2020
@googlebot
Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@knative-prow-robot knative-prow-robot merged commit 122514b into knative:release-0.13 Mar 5, 2020
@isdal
Copy link
Copy Markdown

isdal commented Mar 5, 2020

cla label updated. Odd.

@vagababov
Copy link
Copy Markdown
Contributor

/label cla: yes
remove-label cla: no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants