Mutate - to _ in component names for metrics#1145
Merged
Merged
Conversation
knative-prow-robot
added
the
size/S
Member
evankanderson
left a comment
evankanderson
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Thanks for finding/debugging this!
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, pmorie The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
pmorie
added a commit
to pmorie/pkg
that referenced
this pull request
Mar 6, 2020
knative-prow-robot
pushed a commit
that referenced
this pull request
Mar 6, 2020
This was referenced Mar 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing
-in will create invalid metric names for prometheus (at least); mutate it on the way in.As a follow-up, we need to add validation for the component name on the way into metrics.