Skip to content

Updating duckv1.SourceStatus to include CloudEventAttributes#1165

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
nachocano:rt_registry
Mar 20, 2020
Merged

Updating duckv1.SourceStatus to include CloudEventAttributes#1165
knative-prow-robot merged 1 commit into
knative:masterfrom
nachocano:rt_registry

Conversation

@nachocano
Copy link
Copy Markdown
Contributor

@nachocano nachocano commented Mar 17, 2020

/assign @lionelvillard @n3wscott @vaikas @mattmoor

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 17, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 17, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 17, 2020
@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Mar 17, 2020

The following is the coverage report on the affected files.
Say /test pull-knative-pkg-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
apis/duck/v1/source_types.go 9.1% 8.3% -0.8

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Mar 17, 2020

@nachocano: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-pkg-go-coverage 35afaa9 link /test pull-knative-pkg-go-coverage

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nachocano nachocano mentioned this pull request Mar 17, 2020
Merged
n3wscott
n3wscott reviewed Mar 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A type and source touple might not be what we want, let's take a look at the cloudevents discovery api that we are working on. In that source has a list of event types. More tomorrow...

mikehelmick
mikehelmick reviewed Mar 19, 2020
View reviewed changes
Comment thread apis/duck/v1/source_types.go
@n3wscott
Copy link
Copy Markdown
Contributor

n3wscott commented Mar 20, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Mar 20, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2020
@nachocano nachocano changed the title [WIP] Updating duckv1.SourceStatus to include CloudEventAttributes Updating duckv1.SourceStatus to include CloudEventAttributes Mar 20, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2020
@mikehelmick
Copy link
Copy Markdown

mikehelmick commented Mar 20, 2020

/lgtm

@nachocano
Copy link
Copy Markdown
Contributor Author

nachocano commented Mar 20, 2020

Synced offline with @mikehelmick , he is fine with letting this in so that we can maintain current functionality and unblock the refactor PRs:
knative/eventing#2770
knative/eventing-contrib#1036

We will revisit EventType in knative/eventing#2750

@knative-prow-robot knative-prow-robot merged commit 381424b into knative:master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattmoor mattmoor Awaiting requested review from mattmoor

@vaikas vaikas Awaiting requested review from vaikas

2 more reviewers

@mikehelmick mikehelmick mikehelmick left review comments

@n3wscott n3wscott n3wscott left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mikehelmick mikehelmick

@mattmoor mattmoor

@lionelvillard lionelvillard

@vaikas vaikas

@n3wscott n3wscott

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@nachocano @knative-metrics-robot @knative-prow-robot @n3wscott @mikehelmick @mattmoor @googlebot @lionelvillard @vaikas