Skip to content

Make Channelable match the definition in https://github.com/knative/eventing/pull/482. #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow-robot merged 1 commit into from
Oct 26, 2018
Merged

Make Channelable match the definition in https://github.com/knative/eventing/pull/482. #134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions apis/duck/v1alpha1/channelable_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@ type Channelable struct {
}

// ChannelSubscriberSpec defines a single subscriber to a Channel.
// CallableDomain is the endpoint for the call
// SinkableDomain is the endpoint for the result
// One of them must be present
// CallableURI is the endpoint for the call
// SinkableURI is the endpoint for the result
// At least one of them must be present.
type ChannelSubscriberSpec struct {
// +optional
CallableDomain string `json:"callableDomain,omitempty"`
CallableURI string `json:"callableURI,omitempty"`
// +optional
SinkableDomain string `json:"sinkableDomain,omitempty"`
SinkableURI string `json:"sinkableURI,omitempty"`
}


Expand Down