add metrics constants for resource type and labels#168
Merged
Conversation
knative-prow-robot
added
size/M
Contributor
Author
|
/assign @mdemirhan @yanweiguo |
mdemirhan
suggested changes
Nov 20, 2018
yanweiguo
reviewed
Nov 20, 2018
Contributor
Author
|
Updated per your suggestions. Please take a look again. Thanks! |
Contributor
Author
|
/test pull-knative-pkg-unit-tests |
yanweiguo
reviewed
Nov 20, 2018
| // ResourceTypeKnativeRevision is the Stackdriver resource type for Knative revision | ||
| ResourceTypeKnativeRevision = "knative_revision" | ||
|
|
||
| // LabelProject is the label for project number (gaia id) |
Contributor
There was a problem hiding this comment.
What will this be if knative is not running on GKE?
yanweiguo
reviewed
Nov 20, 2018
Contributor
Author
|
Gentle ping |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akyyy, yanweiguo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
chengjingtao
pushed a commit
to katanomi/knative-pkg
that referenced
this pull request
Oct 22, 2024
knative#161) * feat:add function to list commit and add additional information to commit * feat:set status for list commitstatus when one commit failed (knative#168) * add debug log * feat: Add pagging metadata to ListMeta * feat: Adds convert http response error into kubernetes error * fix: boilerplate on new file Co-authored-by: jjzhang <jjzhang@alauda.io> Co-authored-by: Daniel <danielfbm@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.