Skip to content

Skip at BackgroundOperation's verify stage doesn't hang tests#1912

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
cardil:bugfix/fix-skip-at-verify
Nov 17, 2020
Merged

Skip at BackgroundOperation's verify stage doesn't hang tests#1912
knative-prow-robot merged 1 commit into
knative:masterfrom
cardil:bugfix/fix-skip-at-verify

Conversation

@cardil
Copy link
Copy Markdown
Contributor

@cardil cardil commented Nov 17, 2020

Fixes #1911

Changes

  • Issuing a Skip at BackgroundOperation's verify stage doesn't hang tests anymore

@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 17, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 17, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 17, 2020

Codecov Report

Merging #1912 (3462c94) into master (188df22) will increase coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1912      +/-   ##
==========================================
+ Coverage   69.44%   69.46%   +0.01%     
==========================================
  Files         207      207              
  Lines        8739     8753      +14     
==========================================
+ Hits         6069     6080      +11     
- Misses       2401     2402       +1     
- Partials      269      271       +2
Impacted Files Coverage Δ
network/handlers/drain.go 82.50% <50.00%> (-5.74%) ⬇️
network/network.go 100.00% <100.00%> (ø)
test/upgrade/functions.go 100.00% <100.00%> (ø)
test/gcs/mock/mock.go 91.39% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 188df22...c317721. Read the comment docs.

aliok
aliok approved these changes Nov 17, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for fixing this.
defer and fixed order FTW?

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2020
@chaodaiG
Copy link
Copy Markdown
Contributor

chaodaiG commented Nov 17, 2020

/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Nov 17, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, cardil, chaodaiG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2020
@knative-prow-robot knative-prow-robot merged commit ac327c4 into knative:master Nov 17, 2020
@cardil cardil deleted the bugfix/fix-skip-at-verify branch November 17, 2020 19:37
cardil added a commit to cardil/knative-eventing that referenced this pull request Nov 17, 2020
@cardil
Update deps to include knative/pkg#1912
cd5a8bb
knative-prow-robot pushed a commit to knative/eventing that referenced this pull request Nov 27, 2020
@cardil
Migrate upgrade tests to use new framework (#4519)
6065b38 
* Migrate upgrade tests to use new framework

* Lint fixes

* Fixing shell outs

* Removal of unneeded vandor

* Lint fixes

* Unit test fixes

* Update deps to include knative/pkg#1912

* Fix unit test when running without proper git checkout

* Using new shell-out package from knative.dev/hack

* Fixing code style

* Adjusting location of project file

We need to point ourselves to specific directory as our scripts are
location sensitive.

* Bash scripts work with set -Eeuo pipefail

* Upgrade knative.dev/hack to include knative/hack#30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aliok aliok aliok approved these changes

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@coryrc coryrc Awaiting requested review from coryrc

Assignees

@aliok aliok

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade test hangs if Skip is invoked in continual operation verification phase

4 participants

@cardil @chaodaiG @knative-prow-robot @aliok