[RELEASE-0.20] Unregister views to avoid slow oom issue during meter cleanup (#2005)#2027
Merged
knative-prow-robot merged 1 commit intoFeb 17, 2021
Conversation
…e#2005) * unregister views * add a test * fix string issue * fix * fixes * fixe races in tests * fix exporter issue * stop meter in cleanup * fixes * typo * revert timeout change * fixes * change msg
knative-prow-robot
added
the
size/M
skonto
changed the title
skonto
changed the title
Codecov Report
@@ Coverage Diff @@
## release-0.20 #2027 +/- ##
=============================================
Coverage 69.06% 69.06%
=============================================
Files 210 210
Lines 8796 8796
=============================================
Hits 6075 6075
+ Misses 2451 2450 -1
- Partials 270 271 +1
Continue to review full report at Codecov.
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #2005, need to pull it downstream as well.
/cc @markusthoemmes @evankanderson