Skip to content

[RELEASE-0.21] Unregister views to avoid slow oom issue during meter cleanup (#2005)#2101

Closed
skonto wants to merge 1 commit into
knative:mainfrom
skonto:backport_slow_oom_21
Closed

[RELEASE-0.21] Unregister views to avoid slow oom issue during meter cleanup (#2005)#2101
skonto wants to merge 1 commit into
knative:mainfrom
skonto:backport_slow_oom_21

Conversation

@skonto
Copy link
Copy Markdown
Contributor

@skonto skonto commented Apr 23, 2021

Backport of #2005.

…e#2005)

* unregister views

* add a test

* fix string issue

* fix

* fixes

* fixe races in tests

* fix exporter issue

* stop meter in cleanup

* fixes

* typo

* revert timeout change

* fixes

* change msg
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 23, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign yanweiguo after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanweiguo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 23, 2021
@skonto
Copy link
Copy Markdown
Contributor Author

skonto commented Apr 23, 2021

wrong branch.

@skonto skonto closed this Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants