Skip to content

Add context wrappers to genreconciler#2147

Closed
slinkydeveloper wants to merge 2 commits into
knative:mainfrom
slinkydeveloper:main
Closed

Add context wrappers to genreconciler#2147
slinkydeveloper wants to merge 2 commits into
knative:mainfrom
slinkydeveloper:main

Conversation

@slinkydeveloper
Copy link
Copy Markdown
Contributor

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Changes

  • 🎁 Now generated reconcilers can get a context wrapper injected on every Reconcile method invocation

/kind

Fixes #

Release Note


Docs


Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@knative-prow-robot
Copy link
Copy Markdown
Contributor

@slinkydeveloper: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

Details

In response to this:

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Changes

  • 🎁 Now generated reconcilers can get a context wrapper injected on every Reconcile method invocation

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: slinkydeveloper
To complete the pull request process, please assign richieescarez after the PR has been reviewed.
You can assign the PR to them by writing /assign @richieescarez in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 8, 2021
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 8, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 8, 2021

Codecov Report

Merging #2147 (f41341e) into main (0e61d67) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2147   +/-   ##
=======================================
  Coverage   67.56%   67.57%           
=======================================
  Files         215      216    +1     
  Lines        9098     9100    +2     
=======================================
+ Hits         6147     6149    +2     
  Misses       2676     2676           
  Partials      275      275           
Impacted Files Coverage Δ
.../injection-gen/generators/reconciler_controller.go 0.00% <ø> (ø)
.../injection-gen/generators/reconciler_reconciler.go 0.00% <ø> (ø)
controller/options.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e61d67...f41341e. Read the comment docs.

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Copy link
Copy Markdown
Contributor Author

For more context on how this can be useful: knative/eventing#5440 (comment)

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@slinkydeveloper: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2021
@dprotaso
Copy link
Copy Markdown
Member

Going to close this out as slinky has left

@dprotaso dprotaso closed this Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants