Skip to content

drop deprecated enabledComponents field#2162

Merged
knative-prow-robot merged 1 commit intoknative:mainfrom
dprotaso:drop-deprecated-field
Jun 22, 2021
Merged

drop deprecated enabledComponents field#2162
knative-prow-robot merged 1 commit intoknative:mainfrom
dprotaso:drop-deprecated-field

Conversation

@dprotaso
Copy link
Copy Markdown
Member

@dprotaso dprotaso commented Jun 18, 2021

Fixes: #1478

@knative-prow-robot knative-prow-robot added area/test-and-release approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 18, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 18, 2021
@dprotaso dprotaso force-pushed the drop-deprecated-field branch from b32ca9a to 58f52b9 Compare June 18, 2021 18:58
@dprotaso
Copy link
Copy Markdown
Member Author

/hold

screwed up the base branch

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2021
@dprotaso dprotaso force-pushed the drop-deprecated-field branch from 58f52b9 to 3f6e570 Compare June 18, 2021 18:59
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 18, 2021
@dprotaso
Copy link
Copy Markdown
Member Author

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 18, 2021

Codecov Report

Merging #2162 (3f6e570) into main (841aa73) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2162      +/-   ##
==========================================
+ Coverage   65.94%   65.99%   +0.04%     
==========================================
  Files         222      222              
  Lines        9395     9395              
==========================================
+ Hits         6196     6200       +4     
+ Misses       2918     2916       -2     
+ Partials      281      279       -2     
Impacted Files Coverage Δ
leaderelection/config.go 77.27% <ø> (ø)
test/gcs/mock/mock.go 92.47% <0.00%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f454995...3f6e570. Read the comment docs.

@dprotaso
Copy link
Copy Markdown
Member Author

/assign @markusthoemmes

Copy link
Copy Markdown
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [dprotaso,markusthoemmes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 7521c92 into knative:main Jun 22, 2021
@dprotaso dprotaso deleted the drop-deprecated-field branch June 22, 2021 14:33
knative-prow-robot pushed a commit to knative/operator that referenced this pull request Aug 30, 2021
…735)

This patch removes deprecated `enabledComponents` field in config-leader-election

It was removed since 1 year ago knative/pkg#2162.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the EnabledComponents field.

3 participants