Skip to content

fix check calls being unreliable#2250

Merged
knative-prow-robot merged 2 commits intoknative:mainfrom
leetcope:make-check-calls-more-reliable
Sep 2, 2021
Merged

fix check calls being unreliable#2250
knative-prow-robot merged 2 commits intoknative:mainfrom
leetcope:make-check-calls-more-reliable

Conversation

@leetcope
Copy link
Copy Markdown
Contributor

@leetcope leetcope commented Sep 1, 2021

Add back DefaultErrorRetryChecker into the CheckEndpointState calls so it retries for issues caused by the network.

Problem introduced in knative/serving/pull/11680

@leetcope
fix check calls being unreliable
79a8e2e 
Signed-off-by: Fabian Lopez <lfabian@vmware.com>
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 1, 2021
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/test-and-release labels Sep 1, 2021
@dprotaso
Copy link
Copy Markdown
Member

dprotaso commented Sep 2, 2021

/assign @markusthoemmes @nak3

@dprotaso
Copy link
Copy Markdown
Member

dprotaso commented Sep 2, 2021

/retest

markusthoemmes
markusthoemmes approved these changes Sep 2, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 2, 2021
@markusthoemmes
Copy link
Copy Markdown
Contributor

markusthoemmes commented Sep 2, 2021

/retest

@markusthoemmes
Copy link
Copy Markdown
Contributor

markusthoemmes commented Sep 2, 2021

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 2, 2021
markusthoemmes
markusthoemmes reviewed Sep 2, 2021
View reviewed changes
Comment thread test/spoof/spoof.go Outdated
}
}
}
sc.Logf("NOT Retrying %s: %v", req.URL.String(), err)
Copy link
Copy Markdown
Contributor

@markusthoemmes markusthoemmes Sep 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This log line should move into the if err != nil block I believe.

@leetcope
move log output inside error check if statement
29d16e1 
Signed-off-by: Fabian Lopez <lfabian@vmware.com>
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2021
markusthoemmes
markusthoemmes approved these changes Sep 2, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Sep 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, shinigambit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 2, 2021 •
edited
Loading

Codecov Report

Merging #2250 (29d16e1) into main (f39ea04) will increase coverage by 0.12%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2250      +/-   ##
==========================================
+ Coverage   63.92%   64.04%   +0.12%     
==========================================
  Files         220      221       +1     
  Lines        9550     9605      +55     
==========================================
+ Hits         6105     6152      +47     
- Misses       3172     3177       +5     
- Partials      273      276       +3
Impacted Files Coverage Δ
test/spoof/spoof.go 48.17% <57.14%> (-0.27%) ⬇️
test/gcs/mock/mock.go 90.32% <0.00%> (-1.08%) ⬇️
webhook/resourcesemantics/defaulting/defaulting.go 79.62% <0.00%> (-0.50%) ⬇️
...k/resourcesemantics/validation/validation_admit.go 92.94% <0.00%> (-0.32%) ⬇️
leaderelection/context.go 91.81% <0.00%> (ø)
webhook/json/decode.go 96.29% <0.00%> (ø)
reconciler/leader.go 100.00% <0.00%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f39ea04...29d16e1. Read the comment docs.

@markusthoemmes
Copy link
Copy Markdown
Contributor

markusthoemmes commented Sep 2, 2021

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 2, 2021
@knative-prow-robot knative-prow-robot merged commit b721b0b into knative:main Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@markusthoemmes markusthoemmes markusthoemmes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@markusthoemmes markusthoemmes

@nak3 nak3

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@leetcope @dprotaso @markusthoemmes @knative-prow-robot @nak3