🐛 TestDialWithBackoff work without special environment

[cardil]

Changes

• 🐛 TestDialWithBackoff work without special environment

/kind bug

Fixes #2401

[cardil]

/cc @vagababov
/cc @tcnghia
/cc @mattmoor

[knative-prow-robot]

@cardil: GitHub didn't allow me to request PR reviews from the following users: Chizh.

Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @vagababov
/cc @tcnghia
/cc @Chizh
/cc @mattmoor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cardil]

/cc @chizhg

[codecov]

Codecov Report

Merging #2402 (abf66bb) into main (12be060) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2402   +/-   ##
=======================================
  Coverage   81.71%   81.71%           
=======================================
  Files         163      163           
  Lines        9653     9653           
=======================================
  Hits         7888     7888           
  Misses       1529     1529           
  Partials      236      236           

Impacted Files	Coverage Δ
network/transports.go	71.95% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12be060...abf66bb. Read the comment docs.

[cardil]

The unit test failures 1486341657388388352 look unrelated:

/test pull-knative-pkg-unit-tests

[chizhg]

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cardil, chizhg
To complete the pull request process, please assign tcnghia after the PR has been reviewed.
You can assign the PR to them by writing /assign @tcnghia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• network/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[evankanderson]

Rather than using a likely-non-routable IP, how about using Listen's backlog to force a timeout? (This is similar to the localhost IP range suggestion, but more likely to consistently work)

cardil#1

Note that both this PR and the current state in main don't work on Windows, with similar errors:

--- FAIL: TestDialWithBackoff (0.17s)
    --- FAIL: TestDialWithBackoff/ConnectionRefused (0.09s)
        transports_test.go:107: Unexpected error: timed out dialing after 0.09s
--- FAIL: TestDialTLSWithBackoff (0.19s)
    --- FAIL: TestDialTLSWithBackoff/ConnectionRefused (0.09s)
        transports_test.go:107: Unexpected error: timed out dialing after 0.09s

As a side note, putting all of these in one test makes it harder (for example) to run just the DialWithBackoffTimout test from VSCode -- you can click on "run test" above methods named TestFoo to run just that test, but in this case, you have to run the TestDialWithBackoff tests as a whole.

[cardil]

At @evankanderson:

Rather than using a likely-non-routable IP, how about using Listen's backlog to force a timeout? cardil#1

Interesting. I'll continue on this next week.

Note that both this PR and the current state in main don't work on Windows, with similar errors

I did run those tests multiple times, but apparently they also failed on Prow. It looks to me like your solution could help. Thanks! I'll take a look next week.

As a side note, putting all of these in one test makes it harder to run just one test

That's a bummer. I use Goland, and there I could easily execute those subtests. VSCode should also have this feature.

[evankanderson]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, chizhg, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• network/OWNERS [evankanderson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment