Skip to content

Conversation

@evankanderson
Copy link
Member

See knative/serving#13399 (comment)

When we added warning-level api.FieldErrors, we missed filtering the warnings from ValidateCreates and ValidateUpdates.
For knative/serving#13399, we want to be able to issue warnings on insecure default values for containers, but we don't want to force all our existing tests to use secure default values (and we want to validate that the insecure values will still work for controllers, etc).

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 17, 2022
@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Base: 81.33% // Head: 81.28% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (1b1ea86) compared to base (714b763).
Patch coverage: 61.90% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2611      +/-   ##
==========================================
- Coverage   81.33%   81.28%   -0.05%     
==========================================
  Files         162      162              
  Lines        9824     9845      +21     
==========================================
+ Hits         7990     8003      +13     
- Misses       1595     1603       +8     
  Partials      239      239              
Impacted Files Coverage Δ
metrics/config_observability.go 80.35% <61.90%> (-11.08%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@evankanderson
Copy link
Member Author

/assign @psschwei @mattmoor

Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2022
@knative-prow
Copy link

knative-prow bot commented Oct 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 5cbee02 into knative:main Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants