Fix WEBHOOK_DISABLE_NAMESPACE_OWNERSHIP env-var

[thesuperzapper]

Changes

• Fixes the implementation from Add WEBHOOK_DISABLE_NAMESPACE_OWNERSHIP env-var #3103
• Previously, the env-var would not properly apply for knative-serving, because the controller (which adds the owner references) is initialized before the webhook starts (so we need to move the env-var override to the controller constructor).

/kind bug

Related knative/serving#15483

Release Note

Fixed `WEBHOOK_DISABLE_NAMESPACE_OWNERSHIP` env-var

Docs

[knative-prow]

Hi @thesuperzapper. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.

Project coverage is 78.29%. Comparing base (6d10851) to head (eb95a62).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
webhook/configmaps/controller.go	40.00%	2 Missing and 1 partial ⚠️
webhook/resourcesemantics/defaulting/controller.go	25.00%	2 Missing and 1 partial ⚠️
webhook/resourcesemantics/validation/controller.go	25.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3107      +/-   ##
==========================================
- Coverage   78.37%   78.29%   -0.09%     
==========================================
  Files         191      191              
  Lines       11177    11186       +9     
==========================================
- Hits         8760     8758       -2     
- Misses       2153     2162       +9     
- Partials      264      266       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[thesuperzapper]

@dprotaso Sorry for the quick follow-up, but the implementation in #3103 did not quite work in my testing. This PR fixes it, and I have tested it on the deployKF fork of Knative Serving and it works.

NOTE: this PR is based on #3103 so both need to be cherry-picked into any release branches.

[dprotaso]

/lgtm
/approve

/cherry-pick release-1.16

[knative-prow-robot]

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.16 in a new PR and assign it to you.

Details

In response to this:

/lgtm
/approve

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• webhook/OWNERS [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dprotaso]

/ok-to-test

[knative-prow-robot]

@dprotaso: new pull request created: #3108

Details

In response to this:

/lgtm
/approve

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.