[wip] Set Connection: close header when draining HTTP/1#3297
Closed
dprotaso wants to merge 1 commit into
Closed
Conversation
This will trigger the http server to close the connection https://cs.opensource.google/go/go/+/refs/tags/go1.25.4:src/net/http/server.go;l=1389-1391
Member
Author
|
/hold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3297 +/- ##
==========================================
- Coverage 74.58% 74.57% -0.01%
==========================================
Files 188 188
Lines 8187 8185 -2
==========================================
- Hits 6106 6104 -2
Misses 1841 1841
Partials 240 240 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Closing this out - I haven't seen webhook EOFs since I removed the disabling of keep alives |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #3295
This will trigger the http server to close the connection https://cs.opensource.google/go/go/+/refs/tags/go1.25.4:src/net/http/server.go;l=1389-1391
I'm going to hold this PR and see if we need it